Skip to content

[mlir][arith] Add mulf(x, 0) -> 0 to mulf folder #161395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
python3kgae merged 8 commits into from
Oct 2, 2025
Merged

[mlir][arith] Add mulf(x, 0) -> 0 to mulf folder #161395

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7e4a0d4
[mlir][arith] Add mulf(x, 0) -> 0 to mulf folder
Sep 30, 2025
8d49f3f
mulf(NaN, x) -> NaN
Sep 30, 2025
8c72844
Limit to fastmask nnan | ninf
Sep 30, 2025
e86191a
Update per comment.
Sep 30, 2025
bdb0f61
Add nsz.
Sep 30, 2025
18e9504
Remove ninf which is not needed.
Oct 1, 2025
f43001f
Add test for neg zero.
Oct 1, 2025
4019c36
Use CHECK_DAG.
Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mlir/lib/Dialect/Arith/IR/ArithOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,6 +1282,14 @@ OpFoldResult arith::MulFOp::fold(FoldAdaptor adaptor) {
if (matchPattern(adaptor.getRhs(), m_OneFloat()))
return getLhs();

arith::FastMathFlags fmf = getFastmath();
if (arith::bitEnumContainsAll(fmf, arith::FastMathFlags::nnan |
arith::FastMathFlags::ninf)) {
// mulf(x, 0) -> 0
if (matchPattern(adaptor.getRhs(), m_AnyZeroFloat()))
return getRhs();
}

return constFoldBinaryOp<FloatAttr>(
adaptor.getOperands(),
[](const APFloat &a, const APFloat &b) { return a * b; });
Expand Down
10 changes: 10 additions & 0 deletions mlir/test/Dialect/Arith/canonicalize.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2216,6 +2216,16 @@ func.func @test_mulf1(%arg0 : f32, %arg1 : f32) -> (f32) {
return %2 : f32
}

// CHECK-LABEL: @test_mulf2(
func.func @test_mulf2(%arg0 : f32, %arg1 : f32) -> (f32, f32) {
// CHECK-NEXT: %[[C0:.+]] = arith.constant 0.000000e+00 : f32
// CHECK-NEXT: return %[[C0]], %[[C0]]
%c0 = arith.constant 0.0 : f32
%0 = arith.mulf %arg0, %c0 fastmath<nnan,ninf> : f32
%1 = arith.mulf %c0, %arg1 fastmath<nnan,ninf> : f32
return %0, %1 : f32, f32
}

// -----

// CHECK-LABEL: @test_divf(
Expand Down