Skip to content

Conversation

jiang1997
Copy link
Contributor

@jiang1997 jiang1997 commented Sep 30, 2025

This is the second part of the PRs addressing issue #155677.

Copy link

github-actions bot commented Sep 30, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@jiang1997 jiang1997 force-pushed the alignment-attr-op-interface branch from cfbe2ac to 3f081df Compare September 30, 2025 20:58
@jiang1997
Copy link
Contributor Author

Hi @amd-eochoalo,
While grepping for remaining alignment uses, I noticed that most of the call sites aren't the op constructors themselves (as mentioned here), but rather the various lowering/transform passes that extract alignment using getAlignment() directly. For example:

Do you think those call sites should also migrate to getMaybeAlign() as part of this cleanup, or should we keep this change scoped strictly to the constructor signatures for now?

@amd-eochoalo
Copy link
Contributor

@jiang1997 thanks for the contribution! Let's keep this PR small and just focus on the changes you have at the moment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants