-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[libc][POSIX] Add clock_settime() function for Linux #161729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
2c0ef10
06ac55c
7105bef
366ad9a
bd265d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
//===--- clock_settime linux implementation ---------------------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_LIBC_SRC___SUPPORT_TIME_CLOCK_SETTIME_H | ||
#define LLVM_LIBC_SRC___SUPPORT_TIME_CLOCK_SETTIME_H | ||
|
||
#include "hdr/types/clockid_t.h" | ||
#include "hdr/types/struct_timespec.h" | ||
#include "src/__support/error_or.h" | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
namespace internal { | ||
ErrorOr<int> clock_settime(clockid_t clockid, const timespec *ts); | ||
} // namespace internal | ||
} // namespace LIBC_NAMESPACE_DECL | ||
|
||
#endif // LLVM_LIBC_SRC___SUPPORT_TIME_CLOCK_SETTIME_H |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
//===--- clock_settime linux implementation ---------------------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "src/__support/time/clock_settime.h" | ||
#include "hdr/types/clockid_t.h" | ||
#include "hdr/types/struct_timespec.h" | ||
#include "src/__support/OSUtil/syscall.h" | ||
#include "src/__support/common.h" | ||
#include "src/__support/error_or.h" | ||
#include "src/__support/macros/config.h" | ||
#include <sys/syscall.h> | ||
|
||
#if defined(SYS_clock_settime64) | ||
#include <linux/time_types.h> | ||
#endif | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
namespace internal { | ||
ErrorOr<int> clock_settime(clockid_t clockid, const timespec *ts) { | ||
int ret; | ||
#if defined(SYS_clock_settime) | ||
ret = LIBC_NAMESPACE::syscall_impl<int>(SYS_clock_settime, | ||
static_cast<long>(clockid), | ||
reinterpret_cast<long>(ts)); | ||
#elif defined(SYS_clock_settime64) | ||
static_assert( | ||
sizeof(time_t) == sizeof(int64_t), | ||
"SYS_clock_settime64 requires struct timespec with 64-bit members."); | ||
|
||
__kernel_timespec ts64{}; | ||
|
||
ret = LIBC_NAMESPACE::syscall_impl<int>(SYS_clock_settime64, | ||
static_cast<long>(clockid), | ||
reinterpret_cast<long>(&ts64)); | ||
if (ret == 0) { | ||
ts->tv_sec = static_cast<decltype(ts->tv_sec)>(ts64.tv_sec); | ||
ts->tv_nsec = static_cast<decltype(ts->tv_nsec)>(ts64.tv_nsec); | ||
} | ||
#else | ||
#error "SYS_clock_settime and SYS_clock_settime64 syscalls not available." | ||
#endif | ||
if (ret < 0) | ||
return Error(-ret); | ||
return ret; | ||
} | ||
|
||
} // namespace internal | ||
} // namespace LIBC_NAMESPACE_DECL |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
//===-- Implementation header for clock_settime function --------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_LIBC_SRC_TIME_CLOCK_SETTIME_H | ||
#define LLVM_LIBC_SRC_TIME_CLOCK_SETTIME_H | ||
|
||
#include "hdr/types/clockid_t.h" | ||
#include "hdr/types/struct_timespec.h" | ||
#include "src/__support/macros/config.h" | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
|
||
int clock_settime(clockid_t clockid, const timespec *tp); | ||
|
||
} // namespace LIBC_NAMESPACE_DECL | ||
|
||
#endif // LLVM_LIBC_SRC_TIME_CLOCK_SETTIME_H |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
//===---------- Linux implementation of the POSIX clock_settime function --===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "src/time/clock_settime.h" | ||
#include "src/__support/common.h" | ||
#include "src/__support/libc_errno.h" | ||
#include "src/__support/macros/config.h" | ||
#include "src/__support/time/clock_settime.h" | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
|
||
LLVM_LIBC_FUNCTION(int, clock_settime, | ||
(clockid_t clockid, const struct timespec *ts)) { | ||
amemov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
auto result = internal::clock_settime(clockid, ts); | ||
|
||
// A negative return value indicates an error with the magnitude of the | ||
// value being the error code. | ||
if (!result.has_value()) { | ||
libc_errno = result.error(); | ||
return -1; | ||
} | ||
return 0; | ||
} | ||
|
||
} // namespace LIBC_NAMESPACE_DECL |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
//===-- Unittests for clock_settime ---------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "hdr/time_macros.h" | ||
#include "hdr/types/struct_timespec.h" | ||
#include "src/time/clock_settime.h" | ||
#include "test/UnitTest/ErrnoCheckingTest.h" | ||
#include "test/UnitTest/Test.h" | ||
|
||
using LlvmLibcClockSetTime = LIBC_NAMESPACE::testing::ErrnoCheckingTest; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there should also be a test where the syscall succeeds, we want to check both sides of the branch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but the problem with that is that it would require the user the user to run the test as privileged user (through That's the question that I mentioned above, and I'm not exactly sure how to ensure that when some unprivileged user runs it, they would be able to run the test successfully. |
||
#ifdef CLOCK_MONOTONIC | ||
TEST_F(LlvmLibcClockSetTime, MonotonicIsNotSettable) { | ||
timespec ts = {0, 0}; | ||
int result = LIBC_NAMESPACE::clock_settime(CLOCK_MONOTONIC, &ts); | ||
ASSERT_EQ(result, -1); | ||
ASSERT_ERRNO_EQ(EINVAL); | ||
} | ||
#endif // CLOCK_MONOTONIC | ||
|
||
TEST_F(LlvmLibcClockSetTime, InvalidClockId) { | ||
timespec ts = {0, 0}; | ||
int result = LIBC_NAMESPACE::clock_settime(static_cast<clockid_t>(-1), &ts); | ||
ASSERT_EQ(result, -1); | ||
ASSERT_ERRNO_EQ(EINVAL); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: shouldn't we copy values from ts into ts64 before calling doing syscall? E.g. :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do the round trip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SchrodingerZhu , what do you mean?