[lldb] Prevent early exit for weak symbol found in IRExecutionUnit::FindInSymbols #161733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indInSymbols `LoadAddressResolver::Resolve` returns zero for weak symbols. However `FindInSymbols` does multiple searches (each starting with `FindSymbolsWithNameAndType`), and a resolved address of zero from one step of the search should not conclude the search. This change continues the searching for a symbol by only performing an early exit when a concrete address is found. This was identified by an objc class which is available only in newer OSes. Such classes are weak linked. Expressions involving this class were failing, because the search first found the weak linked symbol. rdar://161406615
|
draft while I figure out a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadAddressResolver::Resolvereturns zero for weak symbols. HoweverFindInSymbolsdoes multiple searches (each starting withFindSymbolsWithNameAndType), and a resolved address of zero from one step of the search should not conclude the search.This change continues the searching for a symbol by only performing an early exit when a concrete address is found.
This was identified by an objc class which is available only in newer OSes. Such classes are weak linked. Expressions involving this class were failing, because the search first found the weak linked symbol (which eagerly returned an address of zero).
rdar://161406615