Skip to content

[SystemZ] Fix variable names to reflect Coding Standards #161899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2025
+9 −11
Merged

[SystemZ] Fix variable names to reflect Coding Standards #161899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1922736
fix variable names to reflect standards
dvldogg Oct 3, 2025
6425077
Merge branch 'main' into fix_variable_names
dvldogg Oct 3, 2025
fc48d35
fix variable names to reflect standards
dvldogg Oct 3, 2025
9d30d62
fix issues pointed out by failing check
dvldogg Oct 8, 2025
782e37d
Merge branch 'main' of https://github.com/llvm/llvm-project into fix_…
dvldogg Oct 8, 2025
6c9e43f
Merge remote-tracking branch 'myfork' into fix_variable_names
dvldogg Oct 8, 2025
8f08716
Merge branch 'main' into fix_variable_names
dvldogg Oct 8, 2025
8350d95
indent fix
dvldogg Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
// Output the TLS marker if present.
if ((unsigned)OpNum + 1 < MI->getNumOperands()) {
const MCOperand &MO = MI->getOperand(OpNum + 1);
const MCSymbolRefExpr &refExp = cast<MCSymbolRefExpr>(*MO.getExpr());
switch (refExp.getSpecifier()) {
const MCSymbolRefExpr &RefExp = cast<MCSymbolRefExpr>(*MO.getExpr());
switch (RefExp.getSpecifier()) {
case SystemZ::S_TLSGD:
O << ":tls_gdcall:";
break;
Expand All @@ -195,7 +195,7 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
default:
llvm_unreachable("Unexpected symbol kind");
}
O << refExp.getSymbol().getName();
O << RefExp.getSymbol().getName();
}
}

Expand Down
7 changes: 3 additions & 4 deletions llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@

using namespace llvm;

SystemZConstantPoolValue::
SystemZConstantPoolValue(const GlobalValue *gv,
SystemZCP::SystemZCPModifier modifier)
: MachineConstantPoolValue(gv->getType()), GV(gv), Modifier(modifier) {}
SystemZConstantPoolValue::SystemZConstantPoolValue(
const GlobalValue *GV, SystemZCP::SystemZCPModifier Modifier)
: MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}

SystemZConstantPoolValue *
SystemZConstantPoolValue::Create(const GlobalValue *GV,
Expand Down
7 changes: 3 additions & 4 deletions llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,9 @@ int SystemZHazardRecognizer::groupingCost(SUnit *SU) const {
// Similarly, a group-ending SU may either fit well (last in group), or
// end the group prematurely.
if (SC->EndGroup) {
unsigned resultingGroupSize =
(CurrGroupSize + getNumDecoderSlots(SU));
if (resultingGroupSize < 3)
return (3 - resultingGroupSize);
unsigned ResultingGroupSize = (CurrGroupSize + getNumDecoderSlots(SU));
if (ResultingGroupSize < 3)
return (3 - ResultingGroupSize);
return -1;
}

Expand Down