[libcxx] [ci] Stop manually installing ninja in the Windows build jobs

[mstorsjo]

Ninja is officially included among the preinstalled tools on the Windows runners now.

This should reduce the risk for stray failures here; sometimes, attempting to install Ninja through Chocolatey have caused spurious failures.

[llvmbot]

@llvm/pr-subscribers-libcxx

@llvm/pr-subscribers-github-workflow

Author: Martin Storsjö (mstorsjo)

Changes

Ninja is officially included among the preinstalled tools on the Windows runners now.

This should reduce the risk for stray failures here; sometimes, attempting to install Ninja through Chocolatey have caused spurious failures.

---

Full diff: https://github.com/llvm/llvm-project/pull/161907.diff

1 Files Affected:

• (modified) .github/workflows/libcxx-build-and-test.yaml (-1)

diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 77f79a85a0a2f..b78f2c69408e7 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -255,7 +255,6 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Install dependencies
         run: |
-          choco install -y ninja
           pip install psutil
       - name: Install a current LLVM
         if: ${{ matrix.mingw != true }}

[boomanaiden154]

This might be left over from before the libc++ CI was running inside Github hosted runners?

I guess this makes the workflow less portable if someone wanted to try getting it running again on more powerful windows machines, but given the instability, this seems like a decent enough option for now.

[mstorsjo]

This might be left over from before the libc++ CI was running inside Github hosted runners?

No, this used to be necessary; there was a recent change on github hosted runners to provide ninja pre-installed - see actions/runner-images#11737 and actions/partner-runner-images#96.

I guess this makes the workflow less portable if someone wanted to try getting it running again on more powerful windows machines, but given the instability, this seems like a decent enough option for now.

I guess that's true, but depending on who's providing those more powerful runners, I would kinda expect ninja to be preinstalled anyway - ideally all the necessary tools would be preinstalled in the base image.

[boomanaiden154]

Ah, didn't realize the Github changes were that recent.

Providing everything in the base image definitely makes sense. More things probably need to be reworked either way to get things working on new machines and it's not like this moves the needle at all.

Thanks for the info.