[CI] Update Windows testing to use clang compiler. #162026
Draft
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test whether or not using clang for premerge testing on Windows will improve performance. Currently a work-in-progress: DO NOT REVIEW! DO NOT COMMIT!
|
✅ With the latest revision this PR passed the Python code formatter. |
|
This is only a draft PR. It shows (finally!) how we can get Windows tests to build & use clang-cl (with sccache). I think you said there was a better/faster alternate way of getting clang-cl.exe into the container, so I doubt that this is what we actually want to commit. Let me know how you think we should proceed from here. |
There was a problem hiding this comment.
We should definitely build this into the container. That would be done by adding a step in .github/workflows/containers/github-action-ci-windows/Dockerfile. That lets us pay the installation cost once and a minimal unpacking cost (that we should be able to optimize away eventually) on every run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test whether or not using clang for premerge testing on Windows will improve performance.
Currently a work-in-progress: DO NOT REVIEW! DO NOT COMMIT!