Skip to content

[AMDGPU] Remove calling conv check on entry function #162080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[AMDGPU] Remove calling conv check on entry function #162080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f0b23
[AMDGPU] Remove calling conv check on entry function
jofrn Oct 6, 2025
2f3d478
Add test
jofrn Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,13 +256,6 @@ AMDGPUResourceUsageAnalysisImpl::analyzeResourceUsage(

const Function *Callee = getCalleeFunction(*CalleeOp);

// Avoid crashing on undefined behavior with an illegal call to a
// kernel. If a callsite's calling convention doesn't match the
// function's, it's undefined behavior. If the callsite calling
// convention does match, that would have errored earlier.
if (Callee && AMDGPU::isEntryFunctionCC(Callee->getCallingConv()))
report_fatal_error("invalid call to entry function");

auto isSameFunction = [](const MachineFunction &MF, const Function *F) {
return F == &MF.getFunction();
};
Expand Down
8 changes: 8 additions & 0 deletions llvm/test/CodeGen/AMDGPU/cc-entry.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
; RUN: llc -mtriple=amdgcn -mcpu=gfx1200 < %s 2>&1 | FileCheck %s

define amdgpu_kernel void @entry_fn() {
; CHECK-NOT: LLVM ERROR: invalid call to entry function
entry:
call void @entry_fn()
ret void
}