Skip to content

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Oct 6, 2025

It's important for the name of each benchmark to fully describe the benchmark since we aggregate the results of all benchmarks in a single .lnt file for analysis.

It's important for the name of each benchmark to fully describe
the benchmark since we aggregate the results of all benchmarks
in a single .lnt file for analysis.
@ldionne ldionne requested a review from a team as a code owner October 6, 2025 19:18
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 6, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 6, 2025

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

It's important for the name of each benchmark to fully describe the benchmark since we aggregate the results of all benchmarks in a single .lnt file for analysis.


Full diff: https://github.com/llvm/llvm-project/pull/162139.diff

1 Files Affected:

  • (modified) libcxx/test/benchmarks/bitset.bench.cpp (+2-2)
diff --git a/libcxx/test/benchmarks/bitset.bench.cpp b/libcxx/test/benchmarks/bitset.bench.cpp
index 8fcf52e9425ce..b4c7e6feb6569 100644
--- a/libcxx/test/benchmarks/bitset.bench.cpp
+++ b/libcxx/test/benchmarks/bitset.bench.cpp
@@ -103,7 +103,7 @@ BENCHMARK(BM_BitsetToString<262144>)->Arg(50)->Name("BM_BitsetToString<262144>/U
 BENCHMARK(BM_BitsetToString<524288>)->Arg(50)->Name("BM_BitsetToString<524288>/Uniform (50%)");
 BENCHMARK(BM_BitsetToString<1048576>)->Arg(50)->Name("BM_BitsetToString<1048576>/Uniform (50%)"); // 1 << 20
 
-static void BM_ctor_ull(benchmark::State& state) {
+static void BM_Bitset_ctor_ull(benchmark::State& state) {
   unsigned long long val = (1ULL << state.range(0)) - 1;
   for (auto _ : state) {
     std::bitset<128> b(val);
@@ -111,6 +111,6 @@ static void BM_ctor_ull(benchmark::State& state) {
   }
 }
 
-BENCHMARK(BM_ctor_ull)->DenseRange(1, 63);
+BENCHMARK(BM_Bitset_ctor_ull)->DenseRange(1, 63);
 
 BENCHMARK_MAIN();

@ldionne ldionne merged commit 1b74b7f into llvm:main Oct 14, 2025
75 of 80 checks passed
@ldionne ldionne deleted the review/rename-ctor-ull branch October 14, 2025 16:39
akadutta pushed a commit to akadutta/llvm-project that referenced this pull request Oct 14, 2025
It's important for the name of each benchmark to fully describe the
benchmark since we aggregate the results of all benchmarks in a single
.lnt file for analysis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants