Skip to content

[clang-tidy] Add more constexpr options to readability-identifier-naming #162160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

[clang-tidy] Add more constexpr options to readability-identifier-naming #162160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,17 @@ namespace readability {
m(Member) \
m(ClassConstant) \
m(ClassMember) \
m(ConstexprGlobalVariable) \
m(GlobalConstant) \
m(GlobalConstantPointer) \
m(GlobalPointer) \
m(GlobalVariable) \
m(ConstexprLocalVariable) \
m(LocalConstant) \
m(LocalConstantPointer) \
m(LocalPointer) \
m(LocalVariable) \
m(ConstexprStaticVariable) \
m(StaticConstant) \
m(StaticVariable) \
m(Constant) \
Expand Down Expand Up @@ -1497,8 +1500,19 @@ StyleKind IdentifierNamingCheck::findStyleKindForField(
StyleKind IdentifierNamingCheck::findStyleKindForVar(
const VarDecl *Var, QualType Type,
ArrayRef<std::optional<NamingStyle>> NamingStyles) const {
if (Var->isConstexpr() && NamingStyles[SK_ConstexprVariable])
return SK_ConstexprVariable;
if (Var->isConstexpr()) {
if (Var->isFileVarDecl() && NamingStyles[SK_ConstexprGlobalVariable])
return SK_ConstexprGlobalVariable;

if (Var->isStaticLocal() && NamingStyles[SK_ConstexprStaticVariable])
return SK_ConstexprStaticVariable;

if (Var->isLocalVarDecl() && NamingStyles[SK_ConstexprLocalVariable])
return SK_ConstexprLocalVariable;

if (NamingStyles[SK_ConstexprVariable])
return SK_ConstexprVariable;
}

if (!Type.isNull() && Type.isConstQualified()) {
if (Var->isStaticDataMember() && NamingStyles[SK_ClassConstant])
Expand Down