Skip to content

[X86][GlobalIsel] Support G_IS_FPCLASS #162232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[X86][GlobalIsel] Support G_IS_FPCLASS #162232

wants to merge 1 commit into from
+510 −158

Conversation

mahesh-attarde
Copy link
Contributor

Some of dependency opcodes for G_IS_FPCLASS are now supported. This patch adds lowering for G_IS_FPCLASS.
Test is updated for GISEL Run separately Test PR.

@mahesh-attarde
Copy link
Contributor Author

Current generic lowering differs from SDAG in two ways.

  1. X86 DAG uses signed comparisons where as X86 Generic GISEL adds unsigned compares.
  2. Sequence like xor ecx ecx; or cl, al is not combined in GISEL.

@e-kud e-kud requested review from e-kud, arsenm and RKSimon and removed request for e-kud, arsenm and RKSimon October 7, 2025 08:54
@mahesh-attarde
Copy link
Contributor Author

mahesh-attarde commented Oct 7, 2025 •
edited
Loading

Current generic lowering differs from SDAG in two ways.

  1. X86 DAG uses signed comparisons where as X86 Generic GISEL adds unsigned compares.
  2. Sequence like xor ecx ecx; or cl, al is not combined in GISEL.

Missing Optimization issue #162248

RKSimon
RKSimon approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RKSimon RKSimon RKSimon approved these changes

@e-kud e-kud Awaiting requested review from e-kud

@arsenm arsenm Awaiting requested review from arsenm

Assignees
No one assigned
Labels
backend:X86 llvm:globalisel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahesh-attarde @RKSimon @e-kud @llvmbot