[libc++][atomic] P2835R7: Expose std::atomic_ref's object address
#162236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
|
||
| assert(a.address() == std::addressof(x)); | ||
|
|
||
| static_assert(noexcept((a.address()))); |
There was a problem hiding this comment.
constexpr on address doesn't seem tested. I think it's better to reorganize TestAddress to test constexpr together.
There was a problem hiding this comment.
It's weird that we haven't added constexpr to the constructor. Perhaps test for constexpr should be done in another PR...
There was a problem hiding this comment.
I think it makes sense to complete it after #118382 (P3309R3: constexpr atomic and atomic_ref)
H-G-Hristov
force-pushed
the
hgh/libcxx/P2835R7-Expose-std_atomic_refs-object-address
branch
from
ef90971 to
037a1cb
Compare
frederick-vs-ja
added
libc++
philnik777
reviewed
Oct 7, 2025
Zingam
reviewed
Oct 8, 2025
frederick-vs-ja
approved these changes
Oct 13, 2025
|
Thanks |
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
…lvm#162236) Implements https://wg21.link/P2835R7 Closes llvm#118377 # References - https://wg21.link/atomics.ref.generic.general - https://wg21.link/atomics.ref.int - https://wg21.link/atomics.ref.float - https://wg21.link/atomics.ref.pointer --------- Co-authored-by: Hristo Hristov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://wg21.link/P2835R7
Closes #118377
References