Skip to content

[MLIR][Conversion] PDLToPDLInterp: Don't shadow maximum depth position when creating constraint position. #162265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jumerckx wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[MLIR][Conversion] PDLToPDLInterp: Don't shadow maximum depth position when creating constraint position. #162265

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f625ff7
don't shadow maximum depth position when creating constraint position.
jumerckx Oct 7, 2025
422f2c6
fix
jumerckx Oct 7, 2025
c644851
Merge branch 'main' into jm/constraint_position
jumerckx Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mlir/lib/Conversion/PDLToPDLInterp/PredicateTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,14 +279,14 @@ static void getConstraintPredicates(pdl::ApplyNativeConstraintOp op,
// For each result register a position so it can be used later
for (auto [i, result] : llvm::enumerate(results)) {
ConstraintQuestion *q = cast<ConstraintQuestion>(pred.first);
ConstraintPosition *pos = builder.getConstraintPosition(q, i);
auto [it, inserted] = inputs.try_emplace(result, pos);
ConstraintPosition *constraintPos = builder.getConstraintPosition(q, i);
auto [it, inserted] = inputs.try_emplace(result, constraintPos);
// If this is an input value that has been visited in the tree, add a
// constraint to ensure that both instances refer to the same value.
if (!inserted) {
Position *first = pos;
Position *first = constraintPos;
Position *second = it->second;
if (comparePosDepth(second, first))
if (comparePosDepth(second, pos))
std::tie(second, first) = std::make_pair(first, second);

predList.emplace_back(second, builder.getEqualTo(first));
Expand Down