-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[lldb][windows] add support for out of PATH python.dll resolution #162509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charles-zablit
merged 4 commits into
llvm:main
from
charles-zablit:charles-zablit/windows/delay-python-loading-upstream
Oct 9, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
37cf46e
[lldb][windows] add support for out of PATH python.dll resolution
charles-zablit 2f7a6f1
fixup! [lldb][windows] add support for out of PATH python.dll resolution
charles-zablit e9625a4
address comments
charles-zablit 93c0a4b
fixup! address comments
charles-zablit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for using
$<TARGET_FILE_BASE_NAME:liblldb>.dll
rather than the more straightforward$<TARGET_FILE_NAME:liblldb>
?This patch broke compilation for mingw targets, as these options are specific to the MSVC style build case - and for that case, the DLL name we'd like to pass here has a
lib
prefix, i.e.liblldb.dll
, notlldb.dll
. So instead of trying to manually reapply a prefix and add.dll
at the end, it seems more straightforward to me to just use$<TARGET_FILE_NAME:liblldb>
which should give the right string in both cases?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This used to be gated behind a
if(MSVC)
check in the downstream patch: swiftlang@af218c3. I think that with #162831 we will get a complete solution as ifLLDB_PYTHON_DLL_RELATIVE_PATH
is not set, the mechanism to add to the DLL search path will not even be compiled. If it's set, then it will only work for MSVC and mingw and there will be a warning if it's a different compiler.I agree, this is much better 👍