Skip to content

[mlir][Transforms] Handle attributes in 1-to-many function conversions #162579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −1
Open

[mlir][Transforms] Handle attributes in 1-to-many function conversions #162579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
732ebed
[mlir][Transforms] Handle attributes in 1-to-many function conversions
peterbell10 Oct 9, 2025
ed9821a
Lint
peterbell10 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion mlir/lib/Transforms/Utils/DialectConversion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3789,6 +3789,27 @@ TypeConverter::convertTypeAttribute(Type type, Attribute attr) const {
// FunctionOpInterfaceSignatureConversion
//===----------------------------------------------------------------------===//

static SmallVector<Attribute>
convertFuncOpAttrs(FunctionOpInterface funcOp,
TypeConverter::SignatureConversion &sigConv,
FunctionType newType) {
if (newType.getNumInputs() == funcOp.getNumArguments()) {
return {};
}
ArrayAttr allArgAttrs = funcOp.getAllArgAttrs();
if (!allArgAttrs)
return {};

SmallVector<Attribute> newAttrs(newType.getNumInputs());
for (auto i : llvm::seq(allArgAttrs.size())) {
auto mapping = sigConv.getInputMapping(i);
assert(mapping.has_value());
auto outIdx = mapping->inputNo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if an argument is mapped to multiple block arguments? (I.e., mapping.size > 1.)

newAttrs[outIdx] = allArgAttrs[i];
}
return newAttrs;
}

static LogicalResult convertFuncOpTypes(FunctionOpInterface funcOp,
const TypeConverter &typeConverter,
ConversionPatternRewriter &rewriter) {
Expand All @@ -3809,7 +3830,16 @@ static LogicalResult convertFuncOpTypes(FunctionOpInterface funcOp,
auto newType = FunctionType::get(rewriter.getContext(),
result.getConvertedTypes(), newResults);

rewriter.modifyOpInPlace(funcOp, [&] { funcOp.setType(newType); });
// If using 1-to-n type conversion, we must re-map argument attributes
// to the corresponding new argument index.
auto newArgAttrs = convertFuncOpAttrs(funcOp, result, newType);

rewriter.modifyOpInPlace(funcOp, [&] {
funcOp.setType(newType);
if (!newArgAttrs.empty()) {
funcOp.setAllArgAttrs(newArgAttrs);
}
});

return success();
}
Expand Down