[libcxx][NFC] Added libunwind to LLVM_ENABLE_RUNTIMES for Windows…

[c8ef]

… builds using MinGW.

I tried running the original command, but the error told me I had to include libunwind.

[c8ef]

I also have a minor question regarding the libcxx benchmarks. I know I can use ./build/bin/llvm-lit to run individual test cases, but can I use it to run benchmark files as well?

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Connector Switch (c8ef)

Changes

… builds using MinGW.

I tried running the original command, but the error told me I had to include libunwind.

---

Full diff: https://github.com/llvm/llvm-project/pull/162682.diff

1 Files Affected:

• (modified) libcxx/docs/VendorDocumentation.rst (+1-1)

diff --git a/libcxx/docs/VendorDocumentation.rst b/libcxx/docs/VendorDocumentation.rst
index aede8f9a81dd2..7eba598909a74 100644
--- a/libcxx/docs/VendorDocumentation.rst
+++ b/libcxx/docs/VendorDocumentation.rst
@@ -443,7 +443,7 @@ e.g. the ``mingw-w64-x86_64-clang`` package), together with CMake and ninja.
           -DCMAKE_C_COMPILER=clang                                                    \
           -DCMAKE_CXX_COMPILER=clang++                                                \
           -DLLVM_ENABLE_LLD=ON                                                        \
-          -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"                                   \
+          -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind"                         \
           -DLIBCXXABI_ENABLE_SHARED=OFF                                               \
           -DLIBCXX_ENABLE_STATIC_ABI_LIBRARY=ON
   > ninja -C build cxx

[mstorsjo]

I tried running the original command, but the error told me I had to include libunwind.

That's interesting - can you quote the exact error? I did test this build configuration back when writing the docs, but apparently something has changed somewhere. (It may be some libcxx/libcxxabi internal defaults that have changed.)

Including libunwind clearly is a more complete build setup, how it possibly is built in most cases, but for the original example, I tried to do a setup that was as minimal as possible. But including libunwind should probably make it more robust and be a closer match to what we actually test.

[c8ef]

That's interesting - can you quote the exact error?

CMake Error at C:/Users/xxx/Desktop/llvm-project/libcxxabi/CMakeLists.txt:57 (
message):
  LIBCXXABI_USE_LLVM_UNWINDER is set to ON, but libunwind is not specified in
  LLVM_ENABLE_RUNTIMES.