-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[LLVM][CodeGen][SVE] ASRD cannot represent sdiv-by-one. #162708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6 | ||
; RUN: llc -mattr=+sve -combiner-disabled < %s | FileCheck %s | ||
|
||
target triple = "aarch64-unknown-linux-gnu" | ||
|
||
; Ensure we don't try to represent sdiv-by-one using ARSD. | ||
define <16 x i16> @sdiv_by_one_v16i16(<16 x i16> %a) vscale_range(2,2) { | ||
; CHECK-LABEL: sdiv_by_one_v16i16: | ||
; CHECK: // %bb.0: | ||
; CHECK-NEXT: ptrue p0.h | ||
; CHECK-NEXT: adrp x8, .LCPI0_0 | ||
; CHECK-NEXT: add x8, x8, :lo12:.LCPI0_0 | ||
; CHECK-NEXT: // kill: def $q1 killed $q1 def $z1 | ||
; CHECK-NEXT: // kill: def $q0 killed $q0 def $z0 | ||
; CHECK-NEXT: ld1h { z2.h }, p0/z, [x8] | ||
; CHECK-NEXT: sunpklo z0.s, z0.h | ||
; CHECK-NEXT: sunpklo z1.s, z1.h | ||
; CHECK-NEXT: ptrue p0.s | ||
; CHECK-NEXT: sunpklo z3.s, z2.h | ||
; CHECK-NEXT: ext z2.b, z2.b, z2.b, #16 | ||
; CHECK-NEXT: sunpklo z2.s, z2.h | ||
; CHECK-NEXT: sdiv z0.s, p0/m, z0.s, z3.s | ||
; CHECK-NEXT: sdiv z1.s, p0/m, z1.s, z2.s | ||
; CHECK-NEXT: ptrue p0.h, vl8 | ||
; CHECK-NEXT: uzp1 z0.h, z0.h, z0.h | ||
; CHECK-NEXT: uzp1 z1.h, z1.h, z1.h | ||
; CHECK-NEXT: splice z0.h, p0, z0.h, z1.h | ||
; CHECK-NEXT: movprfx z1, z0 | ||
; CHECK-NEXT: ext z1.b, z1.b, z0.b, #16 | ||
; CHECK-NEXT: // kill: def $q0 killed $q0 killed $z0 | ||
; CHECK-NEXT: // kill: def $q1 killed $q1 killed $z1 | ||
; CHECK-NEXT: ret | ||
%res = sdiv <16 x i16> %a, splat(i16 1) | ||
ret <16 x i16> %res | ||
} | ||
|
||
; Ensure we don't try to represent sdiv-by-one using ARSD. | ||
define <vscale x 8 x i16> @sdiv_by_one_nxv8i16(<vscale x 8 x i16> %a) { | ||
; CHECK-LABEL: sdiv_by_one_nxv8i16: | ||
; CHECK: // %bb.0: | ||
; CHECK-NEXT: mov z1.h, #1 // =0x1 | ||
; CHECK-NEXT: sunpkhi z2.s, z0.h | ||
; CHECK-NEXT: sunpklo z0.s, z0.h | ||
; CHECK-NEXT: ptrue p0.s | ||
; CHECK-NEXT: sunpkhi z3.s, z1.h | ||
; CHECK-NEXT: sunpklo z1.s, z1.h | ||
; CHECK-NEXT: sdiv z2.s, p0/m, z2.s, z3.s | ||
; CHECK-NEXT: sdiv z0.s, p0/m, z0.s, z1.s | ||
; CHECK-NEXT: uzp1 z0.h, z0.h, z2.h | ||
; CHECK-NEXT: ret | ||
%res = sdiv <vscale x 8 x i16> %a, splat(i16 1) | ||
ret <vscale x 8 x i16> %res | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to follow up with an NFC patch to rename the SRAD node to match the instruction it represents.