Skip to content

[mlir] Remove unused local variables (NFC) #163105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

[mlir] Remove unused local variables (NFC) #163105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,12 +464,6 @@ static std::string generateOpDefinition(irdl::detail::dictionary &dict,
auto opStrings = getStrings(op);
fillDict(dict, opStrings);

const auto operandCount = opStrings.opOperandNames.size();
const auto operandNames =
operandCount ? joinNameList(opStrings.opOperandNames) : "{\"\"}";

const auto resultNames = joinNameList(opStrings.opResultNames);

auto resultTypes = llvm::join(
llvm::map_range(opStrings.opResultNames,
[](StringRef attr) -> std::string {
Expand Down
2 changes: 0 additions & 2 deletions mlir/tools/mlir-tblgen/CppGenUtilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ void mlir::tblgen::emitSummaryAndDescComments(llvm::raw_ostream &os,
llvm::StringRef summary,
llvm::StringRef description,
bool terminateComment) {

std::string comments = "";
StringRef trimmedSummary = summary.trim();
StringRef trimmedDesc = description.trim();
raw_indented_ostream ros(os);
Expand Down
4 changes: 0 additions & 4 deletions mlir/unittests/IR/RemarkTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ TEST(Remark, TestNoOutputOptimizationRemark) {

std::string categoryFailName("myImportantCategory");
std::string myPassname1("myPass1");
std::string funcName("myFunc");
SmallString<64> tmpPathStorage;
sys::fs::createUniquePath("remarks-%%%%%%.yaml", tmpPathStorage,
/*MakeAbsolute=*/true);
Expand Down Expand Up @@ -271,9 +270,6 @@ TEST(Remark, TestCustomOptimizationRemarkDiagnostic) {
std::string categoryInline("Inliner");
std::string myPassname1("myPass1");
std::string myPassname2("myPass2");
std::string funcName("myFunc");

std::string seenMsg = "";

{
MLIRContext context;
Expand Down