Skip to content

[AMDGPU] expand-fp: always report modifications #163153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
Merged

[AMDGPU] expand-fp: always report modifications #163153

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5addea
[AMDGPU] expand-fp: always report modifications
frederik-h Oct 13, 2025
0ea427f
expand-fp: Move "Modified" check
frederik-h Oct 13, 2025
e66365c
Trigger tests
frederik-h Oct 13, 2025
11b69f4
Revert "expand-fp: Move "Modified" check"
frederik-h Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/lib/CodeGen/ExpandFp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,7 @@ static bool runImpl(Function &F, const TargetLowering &TLI,
continue;

addToWorklist(I, Worklist);
Modified = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing all the assignments on add to worklist, and do it once when processing the worklist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possible provided scalarize always pushes to the Worklist, i.e. the instructions created in this function cannot be folded. This seems to hold true for the instructions handled in this pass. I have implemented the change accordingly in this commit. Does that make sense or should I perhaps pass NoFolder to the IRBuilder ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert the additional changes for now to fix the build bot failures. We can still add them in a follow-up PR.

break;
}
default:
Expand Down