-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[AArch64][llvm] Armv9.7-A: Add support for SVE2p3 DOT and MLA operations #163161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c5161a8
[AArch64][llvm] Armv9.7-A: Add support for SVE2p3 DOT and MLA operations
jthackray 1bf2e06
fixup! [AArch64][llvm] Armv9.7-A: Add support for SVE2p3 DOT and MLA …
jthackray b90ed8f
fixup! [AArch64][llvm] Armv9.7-A: Add support for SVE2p3 DOT and MLA …
jthackray c9b795c
fixup! [AArch64][llvm] Armv9.7-A: Add support for SVE2p3 DOT and MLA …
jthackray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p2,+f16mm 2>&1 < %s| FileCheck %s | ||
|
|
||
| // --------------------------------------------------------------------------// | ||
| // Invalid element width | ||
|
|
||
jthackray marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fmmla z0.b, z0.b, z0.b | ||
| // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid element width | ||
| // CHECK-NEXT: fmmla z0.b, z0.b, z0.b | ||
| // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: | ||
|
|
||
| movprfx z0.d, p0/z, z6.d | ||
| fmmla z0.h, z2.h, z3.h | ||
| // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: instruction is unpredictable when following a predicated movprfx, suggest using unpredicated movprfx | ||
| // CHECK-NEXT: fmmla z0.h, z2.h, z3.h | ||
| // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p2,+f16mm < %s \ | ||
| // RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST | ||
| // RUN: not llvm-mc -triple=aarch64 -show-encoding < %s 2>&1 \ | ||
| // RUN: | FileCheck %s --check-prefix=CHECK-ERROR | ||
| // RUN: llvm-mc -triple=aarch64 -filetype=obj -mattr=+sve2p2,+f16mm < %s \ | ||
| // RUN: | llvm-objdump -d --mattr=+sve2p2,+f16mm --no-print-imm-hex - | FileCheck %s --check-prefix=CHECK-INST | ||
| // RUN: llvm-mc -triple=aarch64 -filetype=obj -mattr=+sve2p2,+f16mm < %s \ | ||
| // RUN: | llvm-objdump -d --mattr=-sve2p2,-f16mm --no-print-imm-hex - | FileCheck %s --check-prefix=CHECK-UNKNOWN | ||
| // Disassemble encoding and check the re-encoding (-show-encoding) matches. | ||
| // RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sve2p2,+f16mm < %s \ | ||
| // RUN: | sed '/.text/d' | sed 's/.*encoding: //g' \ | ||
| // RUN: | llvm-mc -triple=aarch64 -mattr=+sve2p2,+f16mm -disassemble -show-encoding \ | ||
| // RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST | ||
|
|
||
| fmmla z0.h, z0.h, z0.h | ||
| // CHECK-INST: fmmla z0.h, z0.h, z0.h | ||
| // CHECK-ENCODING: encoding: [0x00,0xe0,0xa0,0x64] | ||
| // CHECK-ERROR: instruction requires: f16mm sve2p2 | ||
| // CHECK-UNKNOWN: 64a0e000 <unknown> | ||
|
|
||
| fmmla z10.h, z10.h, z10.h | ||
| // CHECK-INST: fmmla z10.h, z10.h, z10.h | ||
| // CHECK-ENCODING: encoding: [0x4a,0xe1,0xaa,0x64] | ||
| // CHECK-ERROR: instruction requires: f16mm sve2p2 | ||
| // CHECK-UNKNOWN: 64aae14a <unknown> | ||
|
|
||
| fmmla z21.h, z21.h, z21.h | ||
| // CHECK-INST: fmmla z21.h, z21.h, z21.h | ||
| // CHECK-ENCODING: encoding: [0xb5,0xe2,0xb5,0x64] | ||
| // CHECK-ERROR: instruction requires: f16mm sve2p2 | ||
| // CHECK-UNKNOWN: 64b5e2b5 <unknown> | ||
|
|
||
| fmmla z31.h, z31.h, z31.h | ||
| // CHECK-INST: fmmla z31.h, z31.h, z31.h | ||
| // CHECK-ENCODING: encoding: [0xff,0xe3,0xbf,0x64] | ||
| // CHECK-ERROR: instruction requires: f16mm sve2p2 | ||
| // CHECK-UNKNOWN: 64bfe3ff <unknown> | ||
|
|
||
| movprfx z0, z7 | ||
| fmmla z0.h, z1.h, z2.h | ||
| // CHECK-INST: movprfx z0, z7 | ||
| // CHECK-INST: fmmla z0.h, z1.h, z2.h | ||
| // CHECK-ENCODING: encoding: [0x20,0xe0,0xa2,0x64] | ||
| // CHECK-ERROR: instruction requires: f16mm sve2p2 | ||
| // CHECK-UNKNOWN: 64a2e020 <unknown> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sve-b16mm 2>&1 < %s| FileCheck %s | ||
|
|
||
| // --------------------------------------------------------------------------// | ||
| // Invalid element width | ||
|
|
||
| bfmmla z0.h, z0.b, z0.b | ||
| // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid element width | ||
| // CHECK-NEXT: bfmmla z0.h, z0.b, z0.b | ||
| // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: | ||
|
|
||
| bfmmla z0.s, z0.s, z0.s | ||
| // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid element width | ||
| // CHECK-NEXT: bfmmla z0.s, z0.s, z0.s | ||
| // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: | ||
|
|
||
| bfmmla z0.d, z0.d, z0.d | ||
| // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid element width | ||
| // CHECK-NEXT: bfmmla z0.d, z0.d, z0.d | ||
| // CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sve-b16mm < %s \ | ||
| // RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST | ||
| // RUN: not llvm-mc -triple=aarch64 -show-encoding < %s 2>&1 \ | ||
| // RUN: | FileCheck %s --check-prefix=CHECK-ERROR | ||
| // RUN: llvm-mc -triple=aarch64 -filetype=obj -mattr=+sve-b16mm < %s \ | ||
| // RUN: | llvm-objdump -d --mattr=+sve-b16mm --no-print-imm-hex - | FileCheck %s --check-prefix=CHECK-INST | ||
| // RUN: llvm-mc -triple=aarch64 -filetype=obj -mattr=+sve-b16mm < %s \ | ||
| // RUN: | llvm-objdump -d --mattr=-sve-b16mm --no-print-imm-hex - | FileCheck %s --check-prefix=CHECK-UNKNOWN | ||
| // Disassemble encoding and check the re-encoding (-show-encoding) matches. | ||
| // RUN: llvm-mc -triple=aarch64 -show-encoding -mattr=+sve-b16mm < %s \ | ||
| // RUN: | sed '/.text/d' | sed 's/.*encoding: //g' \ | ||
| // RUN: | llvm-mc -triple=aarch64 -mattr=+sve-b16mm -disassemble -show-encoding \ | ||
| // RUN: | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST | ||
|
|
||
| bfmmla z0.h, z0.h, z0.h | ||
| // CHECK-INST: bfmmla z0.h, z0.h, z0.h | ||
| // CHECK-ENCODING: encoding: [0x00,0xe0,0xe0,0x64] | ||
| // CHECK-ERROR: instruction requires: sve-b16mm | ||
| // CHECK-UNKNOWN: 64e0e000 <unknown> | ||
|
|
||
| bfmmla z10.h, z10.h, z10.h | ||
| // CHECK-INST: bfmmla z10.h, z10.h, z10.h | ||
| // CHECK-ENCODING: encoding: [0x4a,0xe1,0xea,0x64] | ||
| // CHECK-ERROR: instruction requires: sve-b16mm | ||
| // CHECK-UNKNOWN: 64eae14a <unknown> | ||
|
|
||
| bfmmla z21.h, z21.h, z21.h | ||
| // CHECK-INST: bfmmla z21.h, z21.h, z21.h | ||
| // CHECK-ENCODING: encoding: [0xb5,0xe2,0xf5,0x64] | ||
| // CHECK-ERROR: instruction requires: sve-b16mm | ||
| // CHECK-UNKNOWN: 64f5e2b5 <unknown> | ||
|
|
||
| bfmmla z31.h, z31.h, z31.h | ||
| // CHECK-INST: bfmmla z31.h, z31.h, z31.h | ||
| // CHECK-ENCODING: encoding: [0xff,0xe3,0xff,0x64] | ||
| // CHECK-ERROR: instruction requires: sve-b16mm | ||
| // CHECK-UNKNOWN: 64ffe3ff <unknown> | ||
|
|
||
| movprfx z0, z7 | ||
| bfmmla z0.h, z1.h, z2.h | ||
| // CHECK-INST: movprfx z0, z7 | ||
| // CHECK-INST: bfmmla z0.h, z1.h, z2.h | ||
| // CHECK-ENCODING: encoding: [0x20,0xe0,0xe2,0x64] | ||
| // CHECK-ERROR: instruction requires: sve-b16mm | ||
| // CHECK-UNKNOWN: 64e2e020 <unknown> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.