Skip to content

[OpenACC] Fix memory leak for recipe list in Reduction #163219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

[OpenACC] Fix memory leak for recipe list in Reduction #163219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions clang/include/clang/AST/OpenACCClause.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,17 +1325,17 @@ class OpenACCReductionClause final
Op(Operator) {
assert(VarList.size() == Recipes.size());
setExprs(getTrailingObjects<Expr *>(VarList.size()), VarList);
llvm::uninitialized_copy(Recipes,
getTrailingObjects<OpenACCReductionRecipe>());
}

// Initialize the recipe list.
unsigned I = 0;
for (const OpenACCReductionRecipe &R : Recipes) {
new (&getTrailingObjects<OpenACCReductionRecipe>()[I])
OpenACCReductionRecipe(R);
++I;
public:
~OpenACCReductionClause() {
for (unsigned I = 0; I < getExprs().size(); ++I) {
getTrailingObjects<OpenACCReductionRecipe>()[I].~OpenACCReductionRecipe();
}
}

public:
static bool classof(const OpenACCClause *C) {
return C->getClauseKind() == OpenACCClauseKind::Reduction;
}
Expand Down
Loading