Skip to content

[RISCV] Use a tablegen class for AltFmtType. NFC #163251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

[RISCV] Use a tablegen class for AltFmtType. NFC #163251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions llvm/lib/Target/RISCV/RISCVInstrFormats.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,21 @@ def EltDepsVL : EltDeps<vl=1, mask=0>;
def EltDepsMask : EltDeps<vl=0, mask=1>;
def EltDepsVLMask : EltDeps<vl=1, mask=1>;

class EEW <bits<2> val> {
class EEW<bits<2> val> {
bits<2> Value = val;
}
def EEW1 : EEW<0>;
def EEWSEWx1 : EEW<1>;
def EEWSEWx2 : EEW<2>;
def EEWSEWx4 : EEW<3>;

class AltFmtType<bits<2> val> {
bits<2> Value = val;
}
def DONT_CARE_ALTFMT : AltFmtType<0>;
def IS_NOT_ALTFMT : AltFmtType<1>;
def IS_ALTFMT : AltFmtType<2>;

class RVInstCommon<dag outs, dag ins, string opcodestr, string argstr,
list<dag> pattern, InstFormat format> : Instruction {
let Namespace = "RISCV";
Expand Down Expand Up @@ -271,8 +278,8 @@ class RVInstCommon<dag outs, dag ins, string opcodestr, string argstr,
// 0 -> Don't care about altfmt bit in VTYPE.
// 1 -> Is not altfmt.
// 2 -> Is altfmt(BF16).
bits<2> AltFmtType = 0;
let TSFlags{28-27} = AltFmtType;
AltFmtType AltFmtType = DONT_CARE_ALTFMT;
let TSFlags{28-27} = AltFmtType.Value;

// XSfmmbase
bit HasTWidenOp = 0;
Expand Down
3 changes: 0 additions & 3 deletions llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ defvar TAIL_AGNOSTIC = 1;
defvar TU_MU = 0;
defvar TA_MU = 1;
defvar TA_MA = 3;
defvar DONT_CARE_ALTFMT = 0;
defvar IS_NOT_ALTFMT = 1;
defvar IS_ALTFMT = 2;

//===----------------------------------------------------------------------===//
// Utilities.
Expand Down