Skip to content

Conversation

vitalybuka
Copy link
Collaborator

To match lifetime usage order.

@llvmbot
Copy link
Member

llvmbot commented Oct 13, 2025

@llvm/pr-subscribers-llvm-support

Author: Vitaly Buka (vitalybuka)

Changes

To match lifetime usage order.


Full diff: https://github.com/llvm/llvm-project/pull/163278.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/SpecialCaseList.h (+2-2)
diff --git a/llvm/include/llvm/Support/SpecialCaseList.h b/llvm/include/llvm/Support/SpecialCaseList.h
index 466e2a40c9093..477987c576965 100644
--- a/llvm/include/llvm/Support/SpecialCaseList.h
+++ b/llvm/include/llvm/Support/SpecialCaseList.h
@@ -164,6 +164,8 @@ class SpecialCaseList {
   public:
     LLVM_ABI Matcher(bool UseGlobs, bool RemoveDotSlash);
 
+    LLVM_ABI Error insert(StringRef Pattern, unsigned LineNumber);
+
     LLVM_ABI void
     match(StringRef Query,
           llvm::function_ref<void(StringRef Rule, unsigned LineNo)> Cb) const;
@@ -174,8 +176,6 @@ class SpecialCaseList {
       return R;
     }
 
-    LLVM_ABI Error insert(StringRef Pattern, unsigned LineNumber);
-
     std::variant<RegexMatcher, GlobMatcher> M;
     bool RemoveDotSlash;
   };

@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Oct 13, 2025
tarunprabhu and others added 2 commits October 13, 2025 15:05
Created using spr 1.3.6

[skip ci]
Created using spr 1.3.6
@vitalybuka vitalybuka requested a review from fmayer October 13, 2025 22:09
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.nfcspecialcaselist-re-order-methods to main October 13, 2025 22:10
@vitalybuka vitalybuka enabled auto-merge (squash) October 13, 2025 22:10
@vitalybuka vitalybuka merged commit 1b2a956 into main Oct 13, 2025
9 of 12 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcspecialcaselist-re-order-methods branch October 13, 2025 22:45
akadutta pushed a commit to akadutta/llvm-project that referenced this pull request Oct 14, 2025
To match lifetime usage order.

Co-authored-by: Tarun Prabhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:support skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants