Skip to content

[Windows] Fix Registry static data members not exported by extract_symbols.py in static builds with plugin support #163391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

[Windows] Fix Registry static data members not exported by extract_symbols.py in static builds with plugin support #163391

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b9319c
[Windows] Fix plugin registry symbols not exported in static builds w…
zond Oct 14, 2025
3ac4957
Merge branch 'main' into fix-plugin-registry-symbols
zond Oct 21, 2025
2159799
Merge branch 'main' into fix-plugin-registry-symbols
zond Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/utils/extract_symbols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ def should_keep_microsoft_symbol(symbol, calling_convention_decoration):
# Skip X86GenMnemonicTables functions, they are not exposed from llvm/include/.
elif re.match(r"\?is[A-Z0-9]*@X86@llvm", symbol):
return None
# Keep Registry<T>::Head and Registry<T>::Tail static members for plugin support.
# Pattern matches: ?Head@?$Registry@<template_args>@llvm@@ or ?Tail@?$Registry@...
elif (
"?$Registry@" in symbol
and "@llvm@@" in symbol
and (symbol.startswith("?Head@") or symbol.startswith("?Tail@"))
):
return symbol
# Keep mangled llvm:: and clang:: function symbols. How we detect these is a
# bit of a mess and imprecise, but that avoids having to completely demangle
# the symbol name. The outermost namespace is at the end of the identifier
Expand Down