[AsmParser] Upgrade intrinsics without declaration #163402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually calls to intrinsics get auto-upgraded if the intrinsic name/signature changes. However, this currently doesn't happen if the intrinsic declaration is omitted, which is the preferred form in new tests. Make sure that intrinsic calls without declaration also get upgraded.
antoniofrighetto
approved these changes
Oct 14, 2025
| ret void | ||
| } | ||
|
|
||
| define void @no_suffix2() { |
Contributor
There was a problem hiding this comment.
This is convenient for extra coverage, but the intrinsic declaration is not really differing from no_suffix1() (just passing a different pointer), correct?
Contributor
Author
There was a problem hiding this comment.
Right. The purpose of this test is to check that even though no_suffix1 and no_suffix2 both call @llvm.lifetime.start, they get upgraded to two different intrinsics, depending on address space.
dtcxzyw
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually calls to intrinsics get auto-upgraded if the intrinsic name/signature changes. However, this currently doesn't happen if the intrinsic declaration is omitted, which is the preferred form in new tests.
Make sure that intrinsic calls without declaration also get upgraded.