[clang] Add clang::nooutline Attribute #163493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This PR: - Adds a `[[clang::nooutline]]` function attribute for C and C++. There is no equivalent GNU syntax for this attribute, so no `__attribute__` syntax. - Uses the presence of `[[clang::nooutline]]` to add the `nooutline` attribute to IR function definitions. - Turns the `"nooutline"` attribute into an enum attribute (without quotes), and adds an auto-upgrader for bitcode to make that same change to existing IR. - Adds test for the above. The attribute is capable of disabling both the Machine Outliner (enabled at Oz for some targets), and the IR Outliner (disabled by default).
lenary
force-pushed
the
users/lenary/clang-add-nooutline-attr
branch
from
19afc83 to
31c8669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
[[clang::nooutline]]function attribute for C and C++. Thereis no equivalent GNU syntax for this attribute, so no
__attribute__syntax.
[[clang::nooutline]]to add thenooutlineattribute to IR function definitions.
"nooutline"attribute into an enum attribute (withoutquotes), and adds an auto-upgrader for bitcode to make that same
change to existing IR.
The attribute is capable of disabling both the Machine Outliner (enabled
at Oz for some targets), and the IR Outliner (disabled by default).