Skip to content

expand-fp: Refactor modification status handling (NFC) #163542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 20, 2025
Merged

expand-fp: Refactor modification status handling (NFC) #163542

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d929c74
expand-fp: Refactor modification status handling (NFC)
frederik-h Oct 13, 2025
57aa8bf
[AMDGPU] Add test cases for frem with constant operands
frederik-h Oct 16, 2025
221d554
expand-fp: Revert "scalarize" changes
frederik-h Oct 16, 2025
f6407d4
expand-fp: Replace if-else by switch-case in Worklist processing
frederik-h Oct 16, 2025
b0bafea
Merge remote-tracking branch 'upstream/main' into expand-fp-refactor-…
frederik-h Oct 17, 2025
dd2c894
Merge remote-tracking branch 'upstream/main' into expand-fp-refactor-…
frederik-h Oct 17, 2025
707e339
Merge remote-tracking branch 'upstream/main' into expand-fp-refactor-…
frederik-h Oct 17, 2025
4ba6ad9
Merge remote-tracking branch 'upstream/main' into expand-fp-refactor-…
frederik-h Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions llvm/lib/CodeGen/ExpandFp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,10 +941,9 @@ static void scalarize(Instruction *I,
llvm_unreachable("Unsupported instruction type");

Result = Builder.CreateInsertElement(Result, NewOp, Idx);
if (auto *ScalarizedI = dyn_cast<Instruction>(NewOp)) {
ScalarizedI->copyIRFlags(I, true);
Worklist.push_back(ScalarizedI);
}
Instruction *ScalarizedI = cast<Instruction>(NewOp);
ScalarizedI->copyIRFlags(I, true);
Worklist.push_back(ScalarizedI);
}

I->replaceAllUsesWith(Result);
Expand Down Expand Up @@ -993,7 +992,6 @@ static void addToWorklist(Instruction &I,
static bool runImpl(Function &F, const TargetLowering &TLI,
AssumptionCache *AC) {
SmallVector<Instruction *, 4> Worklist;
bool Modified = false;

unsigned MaxLegalFpConvertBitWidth =
TLI.getMaxLargeFPConvertBitWidthSupported();
Expand All @@ -1015,7 +1013,6 @@ static bool runImpl(Function &F, const TargetLowering &TLI,
if (!targetSupportsFrem(TLI, Ty) &&
FRemExpander::canExpandType(Ty->getScalarType())) {
addToWorklist(I, Worklist);
Modified = true;
}
break;
case Instruction::FPToUI:
Expand All @@ -1025,7 +1022,6 @@ static bool runImpl(Function &F, const TargetLowering &TLI,
continue;

addToWorklist(I, Worklist);
Modified = true;
break;
}
case Instruction::UIToFP:
Expand All @@ -1036,14 +1032,14 @@ static bool runImpl(Function &F, const TargetLowering &TLI,
continue;

addToWorklist(I, Worklist);
Modified = true;
break;
}
default:
break;
}
}

bool Modified = !Worklist.empty();
while (!Worklist.empty()) {
Instruction *I = Worklist.pop_back_val();
if (I->getOpcode() == Instruction::FRem) {
Expand Down