Skip to content

[flang][OpenMP] Frontend support for DEVICE_SAFESYNC #163560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 20, 2025
Merged

[flang][OpenMP] Frontend support for DEVICE_SAFESYNC #163560

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4ccd96e
[flang][OpenMP] Set REQUIRES flags on program unit symbol
kparzysz Oct 10, 2025
2fb2af4
[flang][OpenMP] Emit requirements in module files
kparzysz Oct 14, 2025
639f10e
[flang][OpenMP] Dump requirement clauses/flags in WithOmpDeclarative
kparzysz Oct 14, 2025
f353224
format
kparzysz Oct 14, 2025
0ccf7a0
fix typo
kparzysz Oct 14, 2025
0bde017
[flang][OpenMP] Add optional argument to requirement clauses
kparzysz Oct 9, 2025
404527f
[flang][OpenMP] Frontend support for DEVICE_SAFESYNC
kparzysz Oct 11, 2025
54dc59f
Merge branch 'main' into users/kparzysz/q04-optional-arg-requires
kparzysz Oct 16, 2025
cef1c51
Merge branch 'users/kparzysz/q04-optional-arg-requires' into users/kp…
kparzysz Oct 16, 2025
44e964f
Add tests for false argument, and expression folding
kparzysz Oct 16, 2025
010814a
Use version=60 instead of 61
kparzysz Oct 16, 2025
a62b328
bug fix + parser test
kparzysz Oct 16, 2025
9279568
Merge branch 'users/kparzysz/q04-optional-arg-requires' into users/kp…
kparzysz Oct 16, 2025
1657830
Merge branch 'main' into users/kparzysz/q05-more-requires-clauses
kparzysz Oct 16, 2025
4c14770
undo unrelated code movement
kparzysz Oct 17, 2025
6eb23f9
Merge branch 'main' into users/kparzysz/q05-more-requires-clauses
kparzysz Oct 17, 2025
a4e51af
Merge branch 'main' into users/kparzysz/q05-more-requires-clauses
kparzysz Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions flang/test/Parser/OpenMP/requires.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
!RUN: %flang_fc1 -fdebug-unparse -fopenmp -fopenmp-version=50 %s | FileCheck --ignore-case --check-prefix="UNPARSE" %s
!RUN: %flang_fc1 -fdebug-dump-parse-tree -fopenmp -fopenmp-version=50 %s | FileCheck --check-prefix="PARSE-TREE" %s
!RUN: %flang_fc1 -fdebug-unparse -fopenmp -fopenmp-version=60 %s | FileCheck --ignore-case --check-prefix="UNPARSE" %s
!RUN: %flang_fc1 -fdebug-dump-parse-tree -fopenmp -fopenmp-version=60 %s | FileCheck --check-prefix="PARSE-TREE" %s

!$omp requires atomic_default_mem_order(seq_cst)

Expand Down Expand Up @@ -44,4 +44,13 @@
!PARSE-TREE: | | | bool = 'false'
!PARSE-TREE: | Flags = None

!$omp requires device_safesync

!UNPARSE: !$OMP REQUIRES DEVICE_SAFESYNC

!PARSE-TREE: OpenMPDeclarativeConstruct -> OpenMPRequiresConstruct -> OmpDirectiveSpecification
!PARSE-TREE: | OmpDirectiveName -> llvm::omp::Directive = requires
!PARSE-TREE: | OmpClauseList -> OmpClause -> DeviceSafesync
!PARSE-TREE: | Flags = None

end
7 changes: 4 additions & 3 deletions llvm/include/llvm/Frontend/OpenMP/OMP.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,16 +1022,17 @@ def OMP_Requires : Directive<[Spelling<"requires">]> {
let allowedOnceClauses = [
VersionedClause<OMPC_UnifiedAddress>,
VersionedClause<OMPC_UnifiedSharedMemory>,
VersionedClause<OMPC_AtomicDefaultMemOrder>,
VersionedClause<OMPC_DeviceSafesync, 60>,
VersionedClause<OMPC_DynamicAllocators>, VersionedClause<OMPC_SelfMaps>,
// OpenMP 5.2 Spec: If an implementation is not supporting a requirement
// (reverse offload in this case) then it should give compile-time error
// termination.
// Seeting supported version for reverse_offload to a distant future version
// Setting supported version for reverse_offload to a distant future version
// 9.9 so that its partial support can be tested in the meantime.
//
// TODO: Correct this supprted version number whenever complete
// implementation of reverse_offload is available.
VersionedClause<OMPC_AtomicDefaultMemOrder>,
VersionedClause<OMPC_DynamicAllocators>, VersionedClause<OMPC_SelfMaps>,
VersionedClause<OMPC_ReverseOffload, 99>,
];
let association = AS_None;
Expand Down
Loading