Skip to content

[MLIR][MathToXeVM] Remove requirement for ModuleOp op type for MathToXeVM #163619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

[MLIR][MathToXeVM] Remove requirement for ModuleOp op type for MathToXeVM #163619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24fbbcb
remove hard dependency on modules for mathtoxevm
ianayl Oct 15, 2025
d709641
move check-module-behavior.mlir to math-to-xevm.mlir
ianayl Oct 15, 2025
74a6e78
Merge branch 'main' into remove-module-deps
ianayl Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/Conversion/Passes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ def ConvertMathToSPIRVPass : Pass<"convert-math-to-spirv"> {
// MathToXeVM
//===----------------------------------------------------------------------===//

def ConvertMathToXeVM : Pass<"convert-math-to-xevm", "ModuleOp"> {
def ConvertMathToXeVM : Pass<"convert-math-to-xevm"> {
let summary =
"Convert (fast) math operations to native XeVM/SPIRV equivalents";
let description = [{
Expand Down
44 changes: 44 additions & 0 deletions mlir/test/Conversion/MathToXeVM/math-to-xevm.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
// RUN: mlir-opt %s -convert-math-to-xevm='convert-arith=false' \
// RUN: | FileCheck %s -check-prefixes='CHECK,CHECK-NO-ARITH'

// RUN: mlir-opt --pass-pipeline="builtin.module(convert-math-to-xevm)" %s \
// RUN: | FileCheck %s -check-prefixes='CHECK-MODULE,CHECK-ENTIRE-MODULE'
// RUN: mlir-opt --pass-pipeline="builtin.module(gpu.module(convert-math-to-xevm))" %s \
// RUN: | FileCheck %s -check-prefixes='CHECK-MODULE,CHECK-ONLY-GPU'

// This test:
// - check that MathToXeVM converts fastmath math/arith ops properly;
// - check that MathToXeVM handles nested modules while respecting pass manager.

module @test_module {
// CHECK-DAG: llvm.func @_Z22__spirv_ocl_native_expDh(f16) -> f16
// CHECK-DAG: llvm.func @_Z22__spirv_ocl_native_expf(f32) -> f32
Expand Down Expand Up @@ -152,4 +161,39 @@ module @test_module {

return
}

// Check that MathToXeVM handles nested modules while respecting pass manager:

// CHECK-ENTIRE-MODULE: llvm.func @_Z22__spirv_ocl_native_expf(f32) -> f32
// CHECK-ONLY-GPU-NOT: llvm.func @_Z22__spirv_ocl_native_expf(f32) -> f32

// CHECK-MODULE-LABEL: @test_gpu
gpu.module @test_gpu {
// CHECK-MODULE: llvm.func @_Z22__spirv_ocl_native_expf(f32) -> f32
gpu.func @exp_gpu() {
%c1_f32 = arith.constant 1. : f32

// CHECK-MODULE: math.exp
%exp_normal_f32 = math.exp %c1_f32 : f32

// CHECK-MODULE: llvm.call @_Z22__spirv_ocl_native_expf(%{{.*}}) {fastmathFlags = #llvm.fastmath<afn>} : (f32) -> f32
%exp_fast_f32 = math.exp %c1_f32 fastmath<afn> : f32

gpu.return
}
}

// CHECK-MODULE-LABEL: @exp_func
func.func @exp_func() {
%c1_f32 = arith.constant 1. : f32

// CHECK-MODULE: math.exp
%exp_normal_f32 = math.exp %c1_f32 : f32

// CHECK-ENTIRE-MODULE: llvm.call @_Z22__spirv_ocl_native_expf(%{{.*}}) {fastmathFlags = #llvm.fastmath<afn>} : (f32) -> f32
// CHECK-ONLY-GPU: math.exp
%exp_fast_f32 = math.exp %c1_f32 fastmath<afn> : f32

return
}
}