Skip to content

[lldb] Fix the "RegisterValue::SetValueFromData" method for 128-bit integer registers #163646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2025
Merged

[lldb] Fix the "RegisterValue::SetValueFromData" method for 128-bit integer registers #163646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b2fb392
[lldb] fix the "RegisterValue::SetValueFromData" method
Oct 15, 2025
cc54084
[lldb] add tests for the "RegisterValue::SetValueFromData" method
Oct 17, 2025
fdae92f
[lldb] fixing formatting
Oct 17, 2025
592b8f8
[lldb] refactoring
Oct 17, 2025
08ddc99
[lldb] fixing formatting
Oct 17, 2025
812a183
[lldb] refactoring
Oct 17, 2025
86e81ee
[lldb] refactoring
Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Utility/RegisterValue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ Status RegisterValue::SetValueFromData(const RegisterInfo &reg_info,
else if (reg_info.byte_size <= 16) {
uint64_t data1 = src.GetU64(&src_offset);
uint64_t data2 = src.GetU64(&src_offset);
if (src.GetByteOrder() == eByteOrderBig) {
if (src.GetByteOrder() == eByteOrderLittle) {
int128.x[0] = data1;
int128.x[1] = data2;
} else {
Expand Down
40 changes: 40 additions & 0 deletions lldb/unittests/Utility/RegisterValueTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
//===----------------------------------------------------------------------===//

#include "lldb/Utility/RegisterValue.h"
#include "lldb/Utility/DataExtractor.h"
#include "lldb/lldb-private-types.h"
#include "gtest/gtest.h"
#include <optional>

Expand Down Expand Up @@ -54,3 +56,41 @@ TEST(RegisterValueTest, GetScalarValue) {
Scalar((APInt(128, 0xffeeddccbbaa9988ull) << 64) |
APInt(128, 0x7766554433221100)));
}

static const Scalar etalon128(APInt(128, 0xffeeddccbbaa9988ull) << 64 |
APInt(128, 0x7766554433221100ull));

void TestSetValueFromData128(void *src, const lldb::ByteOrder endianness) {
RegisterInfo ri{"uint128_register",
nullptr,
16,
0,
lldb::Encoding::eEncodingUint,
lldb::Format::eFormatDefault,
{0, 0, 0, LLDB_INVALID_REGNUM, 0},
nullptr,
nullptr,
nullptr};
DataExtractor src_extractor(src, 16, endianness, 8);
RegisterValue rv;
EXPECT_TRUE(rv.SetValueFromData(ri, src_extractor, 0, false).Success());
Scalar s;
EXPECT_TRUE(rv.GetScalarValue(s));
EXPECT_EQ(s, etalon128);
}

// Test that the "RegisterValue::SetValueFromData" method works correctly
// with 128-bit little-endian data that represents an integer.
TEST(RegisterValueTest, SetValueFromData_128_le) {
uint8_t src[] = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77,
0x88, 0x99, 0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff};
TestSetValueFromData128(src, lldb::ByteOrder::eByteOrderLittle);
}

// Test that the "RegisterValue::SetValueFromData" method works correctly
// with 128-bit big-endian data that represents an integer.
TEST(RegisterValueTest, SetValueFromData_128_be) {
uint8_t src[] = {0xff, 0xee, 0xdd, 0xcc, 0xbb, 0xaa, 0x99, 0x88,
0x77, 0x66, 0x55, 0x44, 0x33, 0x22, 0x11, 0x00};
TestSetValueFromData128(src, lldb::ByteOrder::eByteOrderBig);
}
Loading