[flang][acc] Implement PointerLikeType API gen[Allocate/Free/Copy] #163660
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| // RUN: fir-opt %s --split-input-file --pass-pipeline="builtin.module(func.func(test-acc-pointer-like-interface{test-mode=alloc}))" 2>&1 | FileCheck %s | ||
|
|
||
| // The tests here use a synthetic hlfir.declare in order to ensure that the hlfir dialect is | ||
| // loaded. This is required because the pass used is part of OpenACC test passes outside of | ||
| // flang and the APIs being test may generate hlfir even when it does not appear. | ||
|
|
||
| func.func @test_ref_scalar_alloc() { | ||
| %0 = fir.alloca f32 {test.ptr} | ||
| %1:2 = hlfir.declare %0 {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation: %{{.*}} = fir.alloca f32 {test.ptr} | ||
| // CHECK: Generated: %{{.*}} = fir.alloca f32 | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_ref_static_array_alloc() { | ||
| %0 = fir.alloca !fir.array<10x20xf32> {test.ptr} | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation: %{{.*}} = fir.alloca !fir.array<10x20xf32> {test.ptr} | ||
| // CHECK: Generated: %{{.*}} = fir.alloca !fir.array<10x20xf32> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_ref_derived_type_alloc() { | ||
| %0 = fir.alloca !fir.type<_QTt{i:i32}> {test.ptr} | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation: %{{.*}} = fir.alloca !fir.type<_QTt{i:i32}> {test.ptr} | ||
| // CHECK: Generated: %{{.*}} = fir.alloca !fir.type<_QTt{i:i32}> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_heap_scalar_alloc() { | ||
| %0 = fir.allocmem f32 {test.ptr} | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation: %{{.*}} = fir.allocmem f32 {test.ptr} | ||
| // CHECK: Generated: %{{.*}} = fir.allocmem f32 | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_heap_static_array_alloc() { | ||
| %0 = fir.allocmem !fir.array<10x20xf32> {test.ptr} | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation: %{{.*}} = fir.allocmem !fir.array<10x20xf32> {test.ptr} | ||
| // CHECK: Generated: %{{.*}} = fir.allocmem !fir.array<10x20xf32> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_ptr_scalar_alloc() { | ||
| %0 = fir.alloca f32 | ||
| %1 = fir.convert %0 {test.ptr} : (!fir.ref<f32>) -> !fir.ptr<f32> | ||
| %2:2 = hlfir.declare %0 {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation | ||
| // CHECK: Generated: %{{.*}} = fir.alloca f32 | ||
| // CHECK: Generated: %{{.*}} = fir.convert %{{.*}} : (!fir.ref<f32>) -> !fir.ptr<f32> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_llvm_ptr_scalar_alloc() { | ||
| %0 = fir.alloca f32 | ||
| %1 = fir.convert %0 {test.ptr} : (!fir.ref<f32>) -> !fir.llvm_ptr<f32> | ||
| %2:2 = hlfir.declare %0 {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation | ||
| // CHECK: Generated: %{{.*}} = fir.alloca f32 | ||
| // CHECK: Generated: %{{.*}} = fir.convert %{{.*}} : (!fir.ref<f32>) -> !fir.llvm_ptr<f32> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_dynamic_array_alloc_fails(%arg0: !fir.ref<!fir.array<?xf32>>) { | ||
| %0 = fir.convert %arg0 {test.ptr} : (!fir.ref<!fir.array<?xf32>>) -> !fir.llvm_ptr<!fir.array<?xf32>> | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Failed to generate alloc for operation: %{{.*}} = fir.convert %{{.*}} {test.ptr} : (!fir.ref<!fir.array<?xf32>>) -> !fir.llvm_ptr<!fir.array<?xf32>> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_unlimited_polymorphic_alloc_fails() { | ||
| %0 = fir.alloca !fir.class<none> {test.ptr} | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Failed to generate alloc for operation: %{{.*}} = fir.alloca !fir.class<none> {test.ptr} | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_dynamic_char_alloc_fails(%arg0: !fir.ref<!fir.char<1,?>>) { | ||
| %0 = fir.convert %arg0 {test.ptr} : (!fir.ref<!fir.char<1,?>>) -> !fir.llvm_ptr<!fir.char<1,?>> | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Failed to generate alloc for operation: %{{.*}} = fir.convert %{{.*}} {test.ptr} : (!fir.ref<!fir.char<1,?>>) -> !fir.llvm_ptr<!fir.char<1,?>> | ||
| return | ||
| } | ||
|
|
||
| // ----- | ||
|
|
||
| func.func @test_static_char_alloc() { | ||
| %0 = fir.alloca !fir.char<1,10> {test.ptr} | ||
| %var = fir.alloca f32 | ||
| %1:2 = hlfir.declare %var {uniq_name = "load_hlfir"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| // CHECK: Successfully generated alloc for operation: %{{.*}} = fir.alloca !fir.char<1,10> {test.ptr} | ||
| // CHECK: Generated: %{{.*}} = fir.alloca !fir.char<1,10> | ||
| return | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fir::hasDynamicSize(eleTy)should be equivalent to what you have here with the exception of howfir.ref<fir.box<None>>/fir.ref<fir.class<None>>is handled.Which leads me to another question, what is the expected behavior of
fir.ref<fir.box/class<T>>? Is it to allocate/free/copy descriptors or to also allocate/free/copy the target data of the descriptor?fir::hasDynamicSizewill acceptfir.ref<fir.box>. If you want to reject them, you can usellvm::isa<fir::BaseBoxType>(eleTy)to detect them.Currently, I think your code is not rejecting
!fir.ref<fir.box<!fir.array<?xf32>>>.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion to use hasDynamicSize - I will use that instead.
I think that
genAllocateshould allow for simple shallow allocations - so allocated descriptor storage is enough.generatePrivateInitfrom MappableType (which is accessible through bothfir.ref<fir.box>andfir.boxshould handle the complexity of allocating both descriptor and data.However, I have decided in the current PR, I will reject boxes in this API and we can revisit if we need shallow allocations of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done