Skip to content

[mlir][AMGPU] Replace use of SmallVector with ArrayRef, NFC #163770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2025
Merged

[mlir][AMGPU] Replace use of SmallVector with ArrayRef, NFC #163770

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f6bde1
[mlir][AMGPU] Replace use of SmallVector with ArrayRef, NFC
Muzammiluddin-Syed-ECE Oct 16, 2025
f3424b3
Infer template arguments where possible
Muzammiluddin-Syed-ECE Oct 16, 2025
4954301
Inferring constant type
Muzammiluddin-Syed-ECE Oct 16, 2025
a02db76
Use int64_t casting
Muzammiluddin-Syed-ECE Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mlir/lib/Dialect/AMDGPU/IR/AMDGPUDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,13 +757,13 @@ struct PackScales final : OpRewritePattern<ScaledMFMAOp> {
offset = numElements - 4l;
}
Type scaleSrcElemType = scaleSrcType.getElementType();
auto newSrcType = VectorType::get(SmallVector<int64_t>({numElements}),
scaleSrcElemType);
auto newSrcType =
VectorType::get(ArrayRef{numElements}, scaleSrcElemType);
Value newScaleSrc =
vector::ShapeCastOp::create(rewriter, loc, newSrcType, scaleSrc);
auto extract = vector::ExtractStridedSliceOp::create(
rewriter, loc, newScaleSrc, ArrayRef<int64_t>{offset},
ArrayRef<int64_t>{size}, ArrayRef<int64_t>{1});
rewriter, loc, newScaleSrc, ArrayRef{offset}, ArrayRef{size},
ArrayRef{INT64_C(1)});
rewriter.modifyOpInPlace(op, [&] {
op->setOperand(opIdx, extract);
setOpsel(opIdx, opsel);
Expand Down
Loading