Skip to content

[sanitizers][windows] Add report on intercept fail to more Rtl* functions. #163818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −12
Open

[sanitizers][windows] Add report on intercept fail to more Rtl* functions. #163818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd25d9
[sanitizers][windows] Add report on intercept fail to more Rtl* funct…
bernhardu Oct 16, 2025
0276554
fixup! [sanitizers][windows] Add report on intercept fail to more Rtl…
bernhardu Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions compiler-rt/lib/asan/asan_malloc_win.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,10 +485,11 @@ INTERCEPTOR_WINAPI(void*, RtlReAllocateHeap, HANDLE HeapHandle, DWORD Flags,

namespace __asan {

static void TryToOverrideFunction(const char *fname, uptr new_func) {
static void TryToOverrideFunction(const char* fname, uptr new_func,
uptr* orig_old_func = 0) {
// Failure here is not fatal. The CRT may not be present, and different CRT
// versions use different symbols.
if (!__interception::OverrideFunction(fname, new_func))
if (!__interception::OverrideFunction(fname, new_func, orig_old_func))
VPrintf(2, "Failed to override function %s\n", fname);
}

Expand Down Expand Up @@ -519,16 +520,14 @@ void ReplaceSystemMalloc() {
ASAN_INTERCEPT_FUNC(HeapAlloc);

// Undocumented functions must be intercepted by name, not by symbol.
__interception::OverrideFunction("RtlSizeHeap", (uptr)WRAP(RtlSizeHeap),
(uptr *)&REAL(RtlSizeHeap));
__interception::OverrideFunction("RtlFreeHeap", (uptr)WRAP(RtlFreeHeap),
(uptr *)&REAL(RtlFreeHeap));
__interception::OverrideFunction("RtlReAllocateHeap",
(uptr)WRAP(RtlReAllocateHeap),
(uptr *)&REAL(RtlReAllocateHeap));
__interception::OverrideFunction("RtlAllocateHeap",
(uptr)WRAP(RtlAllocateHeap),
(uptr *)&REAL(RtlAllocateHeap));
TryToOverrideFunction("RtlSizeHeap", (uptr)WRAP(RtlSizeHeap),
(uptr*)&REAL(RtlSizeHeap));
TryToOverrideFunction("RtlFreeHeap", (uptr)WRAP(RtlFreeHeap),
(uptr*)&REAL(RtlFreeHeap));
TryToOverrideFunction("RtlReAllocateHeap", (uptr)WRAP(RtlReAllocateHeap),
(uptr*)&REAL(RtlReAllocateHeap));
TryToOverrideFunction("RtlAllocateHeap", (uptr)WRAP(RtlAllocateHeap),
(uptr*)&REAL(RtlAllocateHeap));
} else {
#define INTERCEPT_UCRT_FUNCTION(func) \
if (!INTERCEPT_FUNCTION_DLLIMPORT( \
Expand Down