Fix for incomplete buffer types in HLSL #163823
Open
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Sietze Riemersma (KungFuDonkey) ChangesI am actually looking into getting clangd to work with HLSL. There is currently no good tool available for HLSL and as HLSL seems to be supported (up to a certain point) inside clang, I want to see how far I can push the tool to support the different language features. The first feature that requires an update is the SEMA (semantics?) around the buffer types. HLSL has updated their usage of buffer types in recent versions, so these need to be updated here as well. The first issue I ran into is the following;
I will start with 1. in this PR. An explanation for 2. will be later in this post. Please note that I am not familiar with this code base, this is my first time :), so the solution I give here might not be good, but I am willing to learn and move code around if necessary. 1. Some buffers are registered as incomplete typesI have a local test case that is as follows. We have a file: // complete types
RasterizerOrderedStructuredBuffer<float3> buf0 : register(u0);
ConsumeStructuredBuffer<float3> buf1 : register(u0);
AppendStructuredBuffer<float3> buf2 : register(u0);
RWStructuredBuffer<float3> buf3 : register(u0);
StructuredBuffer<float3> buf4 : register(t0);
RasterizerOrderedBuffer<float3> buf5 : register(u0);
Buffer<float3> buf6 : register(t0);
RWBuffer<float3> buf7 : register(u0);
// incomplete types
ByteAddressBuffer buf8 : register(t0);
RWByteAddressBuffer buf9 : register(u0);
RasterizerOrderedByteAddressBuffer buf10 : register(u0);
// missing
ConstantBuffer<float4> buf11 : register(b0);and we call clangd on this file. I have a compile_commands.json that handles cli args (args in output). The output is: Calling Thus, a call to CompleteType is missing for these 3 buffers. I was not able to find where that is. 2.
|
|
@llvm/pr-subscribers-hlsl Author: Sietze Riemersma (KungFuDonkey) ChangesI am actually looking into getting clangd to work with HLSL. There is currently no good tool available for HLSL and as HLSL seems to be supported (up to a certain point) inside clang, I want to see how far I can push the tool to support the different language features. The first feature that requires an update is the SEMA (semantics?) around the buffer types. HLSL has updated their usage of buffer types in recent versions, so these need to be updated here as well. The first issue I ran into is the following;
I will start with 1. in this PR. An explanation for 2. will be later in this post. Please note that I am not familiar with this code base, this is my first time :), so the solution I give here might not be good, but I am willing to learn and move code around if necessary. 1. Some buffers are registered as incomplete typesI have a local test case that is as follows. We have a file: // complete types
RasterizerOrderedStructuredBuffer<float3> buf0 : register(u0);
ConsumeStructuredBuffer<float3> buf1 : register(u0);
AppendStructuredBuffer<float3> buf2 : register(u0);
RWStructuredBuffer<float3> buf3 : register(u0);
StructuredBuffer<float3> buf4 : register(t0);
RasterizerOrderedBuffer<float3> buf5 : register(u0);
Buffer<float3> buf6 : register(t0);
RWBuffer<float3> buf7 : register(u0);
// incomplete types
ByteAddressBuffer buf8 : register(t0);
RWByteAddressBuffer buf9 : register(u0);
RasterizerOrderedByteAddressBuffer buf10 : register(u0);
// missing
ConstantBuffer<float4> buf11 : register(b0);and we call clangd on this file. I have a compile_commands.json that handles cli args (args in output). The output is: Calling Thus, a call to CompleteType is missing for these 3 buffers. I was not able to find where that is. 2.
|
llvm-beanz
requested changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am actually looking into getting clangd to work with HLSL. There is currently no good tool available for HLSL and as HLSL seems to be supported (up to a certain point) inside clang, I want to see how far I can push the tool to support the different language features.
The first feature that requires an update is the SEMA (semantics?) around the buffer types. HLSL has updated their usage of buffer types in recent versions, so these need to be updated here as well.
The first issue I ran into is the following;
ConstantBuffer<type>is missingI will start with 1. in this PR. An explanation for 2. will be later in this post. Please note that I am not familiar with this code base, this is my first time :), so the solution I give here might not be good, but I am willing to learn and move code around if necessary.
1. Some buffers are registered as incomplete types
I have a local test case that is as follows. We have a file:
and we call clangd on this file. I have a compile_commands.json that handles cli args (args in output).
The output is:
Calling
CompleteType(Decl);on the types makes the issues go away for the incomplete buffers:Thus, a call to CompleteType is missing for these 3 buffers. I was not able to find where that is.
2.
ConstantBuffer<type>is missingThis type is in theory the same as saying
cbuffer type.Adding the ConstantBuffer as a new Build in Type here fixes the issue: