Skip to content

[lldb-dap] Send a 'process' event on restart. #163833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[lldb-dap] Send a 'process' event on restart. #163833

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49e0b3b
[lldb-dap] Send a 'process' event on restart.
ashgti Oct 16, 2025
c8fdc73
Restarts should be a 'launch' configuration.
ashgti Oct 16, 2025
b35bc64
Adding `SBPlatform::IsHost` and using it in the lldb-dap event helper.
ashgti Oct 17, 2025
9a0b097
Also adding a python helper for a `is_host` property.
ashgti Oct 17, 2025
66b77f0
Adding a doc string and newline.
ashgti Oct 20, 2025
eee79b0
Merge branch 'main' into lldb-dap-restart-process-event
ashgti Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lldb/tools/lldb-dap/EventHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "Protocol/ProtocolRequests.h"
#include "Protocol/ProtocolTypes.h"
#include "lldb/API/SBFileSpec.h"
#include "lldb/API/SBPlatform.h"
#include "llvm/Support/Error.h"
#include <utility>

Expand Down Expand Up @@ -136,7 +137,9 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) {
EmplaceSafeString(body, "name", exe_path);
const auto pid = dap.target.GetProcess().GetProcessID();
body.try_emplace("systemProcessId", (int64_t)pid);
body.try_emplace("isLocalProcess", true);
body.try_emplace("isLocalProcess",
dap.target.GetPlatform().GetName() ==
lldb::SBPlatform::GetHostPlatform().GetName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose Platform::IsHost through the SB API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could make SBPlatform comparable?

Copy link
Collaborator

@jimingham jimingham Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowing whether the process you are debugging is running locally seems a generally useful piece of information, that should be simple to ask.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added bool SBPlatform::IsHost() const to the lldb API.

const char *startMethod = nullptr;
switch (launch_method) {
case Launch:
Expand Down
2 changes: 2 additions & 0 deletions lldb/tools/lldb-dap/Handler/RestartRequestHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ void RestartRequestHandler::operator()(
return;
}

SendProcessEvent(dap, Launch);

// This is normally done after receiving a "configuration done" request.
// Because we're restarting, configuration has already happened so we can
// continue the process right away.
Expand Down
Loading