Skip to content

[clang] Ensure we don't process OpenCL kernels as CUDA kernels #163859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −4
Open

[clang] Ensure we don't process OpenCL kernels as CUDA kernels #163859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d75ca93
[clang] Ensure we don't process OpenCL kernels as CUDA kernels
sarnex Oct 16, 2025
158e676
swap order
sarnex Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions clang/lib/Sema/SemaDeclAttr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5205,16 +5205,17 @@ static void handleCallConvAttr(Sema &S, Decl *D, const ParsedAttr &AL) {

static void handleDeviceKernelAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
const auto *FD = dyn_cast_or_null<FunctionDecl>(D);
bool IsFunctionTemplate = FD && FD->getDescribedFunctionTemplate();
if (S.getASTContext().getTargetInfo().getTriple().isNVPTX()) {
handleGlobalAttr(S, D, AL);
} else {
if (DeviceKernelAttr::isOpenCLSpelling(AL) ||
!S.getASTContext().getTargetInfo().getTriple().isNVPTX()) {
bool IsFunctionTemplate = FD && FD->getDescribedFunctionTemplate();
// OpenCL C++ will throw a more specific error.
if (!S.getLangOpts().OpenCLCPlusPlus && (!FD || IsFunctionTemplate)) {
S.Diag(AL.getLoc(), diag::err_attribute_wrong_decl_type_str)
<< AL << AL.isRegularKeywordAttribute() << "functions";
}
handleSimpleAttribute<DeviceKernelAttr>(S, D, AL);
} else {
handleGlobalAttr(S, D, AL);
}
// Make sure we validate the CC with the target
// and warn/error if necessary.
Expand Down