Skip to content

[sanitizer][test] Clean up allow_user_segv.cpp test case #163870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2025
Merged

[sanitizer][test] Clean up allow_user_segv.cpp test case #163870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a790144
[sanitizer][test] Clean up allow_user_segv.cpp test case
thurstond Oct 14, 2025
30c11a4
Clarify "builds with assertions" means runtime
thurstond Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions compiler-rt/test/sanitizer_common/TestCases/Linux/allow_user_segv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// Regression test for
// https://code.google.com/p/address-sanitizer/issues/detail?id=180
// Fails with debug checks: https://bugs.llvm.org/show_bug.cgi?id=46860
// XFAIL: !compiler-rt-optimized && tsan

// FIXME: Implement.
// XFAIL: hwasan
Expand Down Expand Up @@ -31,15 +29,12 @@
#include <stdio.h>
#include <stdlib.h>

struct sigaction original_sigaction_sigbus;
struct sigaction original_sigaction_sigsegv;

void User_OnSIGSEGV(int signum, siginfo_t *siginfo, void *context) {
fprintf(stderr, "User sigaction called\n");
struct sigaction original_sigaction = {};
if (signum == SIGBUS)
original_sigaction = original_sigaction_sigbus;
else if (signum == SIGSEGV)
if (signum == SIGSEGV)
original_sigaction = original_sigaction_sigsegv;
else {
printf("Invalid signum");
Expand All @@ -55,11 +50,6 @@ void User_OnSIGSEGV(int signum, siginfo_t *siginfo, void *context) {
exit(1);
}

int DoSEGV() {
volatile int *x = 0;
return *x;
}

bool InstallHandler(int signum, struct sigaction *original_sigaction) {
struct sigaction user_sigaction = {};
user_sigaction.sa_sigaction = User_OnSIGSEGV;
Expand All @@ -72,13 +62,15 @@ bool InstallHandler(int signum, struct sigaction *original_sigaction) {
}

int main() {
// Let's install handlers for both SIGSEGV and SIGBUS, since pre-Yosemite
// 32-bit Darwin triggers SIGBUS instead.
if (InstallHandler(SIGSEGV, &original_sigaction_sigsegv) &&
InstallHandler(SIGBUS, &original_sigaction_sigbus)) {
if (InstallHandler(SIGSEGV, &original_sigaction_sigsegv))
fprintf(stderr, "User sigaction installed\n");
}
return DoSEGV();

// Trying to organically segfault by dereferencing a pointer can be tricky
// when the sanitizer runtime is built with assertions. Additionally, some
// older platforms may SIGBUS instead.
raise(SIGSEGV);

return 0;
}

// CHECK0-NOT: Sanitizer:DEADLYSIGNAL
Expand Down