Skip to content

Conversation

@abhinavgaba
Copy link
Contributor

No description provided.

@abhinavgaba abhinavgaba marked this pull request as ready for review October 17, 2025 04:45
@abhinavgaba
Copy link
Contributor Author

@kparzysz, @CatherineMoore I see that the "ref modifier" row says in-progress for clang after #150700, but there is no comment there.

If you know who's already working on it, please ask them to coordinate with me on the sema/codegen part, because I think it should be done after the pointer-attachment rework is done, to avoid issues.

If no one is working on it, then please let me know and I can claim the row.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 17, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 17, 2025

@llvm/pr-subscribers-clang

Author: Abhinav Gaba (abhinavgaba)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/163908.diff

1 Files Affected:

  • (modified) clang/docs/OpenMPSupport.rst (+5-1)
diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst
index 5c73e2486030e..c75c1703a8dc3 100644
--- a/clang/docs/OpenMPSupport.rst
+++ b/clang/docs/OpenMPSupport.rst
@@ -193,7 +193,7 @@ implementation.
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device                       | support non-contiguous array sections for target update      | :good:`done`             | https://github.com/llvm/llvm-project/pull/144635                      |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| device                       | pointer attachment                                           | :good:`done`             |                                                                       |
+| device                       | pointer attachment                                           | :part:`being repaired`   | @abhinavgaba (https://github.com/llvm/llvm-project/pull/153683)       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | atomic                       | hints for the atomic construct                               | :good:`done`             | D51233                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
@@ -627,6 +627,10 @@ implementation.
 +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
 | loop grid/tile modifiers for sizes clause                   | :none:`unclaimed`         | :none:`unclaimed`         |                                                                          |
 +-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
+| attach map-type modifier                                    | :part:`In Progress`       | :none:`unclaimed`         | C/C++: @abhinavgaba;                                                     |
+|                                                             |                           |                           | RT: @abhinavgaba (https://github.com/llvm/llvm-project/pull/149036,      |
+|                                                             |                           |                           | https://github.com/llvm/llvm-project/pull/158370)                        |
++-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
 
 
 OpenMP Extensions

@abhinavgaba abhinavgaba requested a review from kparzysz October 17, 2025 04:47
@abhinavgaba abhinavgaba merged commit 0319951 into llvm:main Oct 17, 2025
14 checks passed
@abhinavgaba abhinavgaba deleted the update-omp-features-rst branch October 18, 2025 01:31
@jtb20
Copy link
Contributor

jtb20 commented Oct 20, 2025

Hi @abhinavgaba -- the "in progress" was because I was planning to work on that feature, but it didn't make sense to do so while your pointer-attachment work is ongoing. It makes sense for you to take ownership of the ref modifier feature also, I think.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants