Skip to content

Conversation

@MihailMihov
Copy link
Contributor

This PR adds the VTable name _ZTVN10__cxxabiv117__array_type_infoE for Type::ConstantArray, Type::IncompleteArray and Type::VariableArray in ItaniumRTTIBuilder::BuildVTablePointer.

issue #163601

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@MihailMihov
Copy link
Contributor Author

Currently there is no test for this, as I'm not sure how to test it. In the linked issue, throw was suggested, but I don't think that can work for arrays as they always go through the array-to-pointer conversion. typeid can't be used in the tests and I think it's not implemented in CIR.

The only thing that might work is try/catch. I think this would be a correct test for Type::ConstantArray, but try is not yet upstreamed and I don't think that same idea can be applied for Type::IncompleteArray or Type::VariableArray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant