Skip to content

Conversation

@c8ef
Copy link
Contributor

@c8ef c8ef commented Oct 20, 2025

It seems this was accidentally included; there's no use of std::move in this header.

@c8ef c8ef requested a review from a team as a code owner October 20, 2025 15:44
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 20, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 20, 2025

@llvm/pr-subscribers-libcxx

Author: Connector Switch (c8ef)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/164272.diff

1 Files Affected:

  • (modified) libcxx/include/__algorithm/for_each.h (-1)
diff --git a/libcxx/include/__algorithm/for_each.h b/libcxx/include/__algorithm/for_each.h
index e31fcae83a332..c80195a83287f 100644
--- a/libcxx/include/__algorithm/for_each.h
+++ b/libcxx/include/__algorithm/for_each.h
@@ -16,7 +16,6 @@
 #include <__iterator/segmented_iterator.h>
 #include <__type_traits/enable_if.h>
 #include <__type_traits/invoke.h>
-#include <__utility/move.h>
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #  pragma GCC system_header

@frederick-vs-ja
Copy link
Contributor

I guess we don't need to use _LIBCPP_PUSH_MACROS etc. after removing inclusion of <__utility/move.h>. But it's probably fine to keep them.

Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove them, actually. We usually don't put them somewhere unless they're needed.

@c8ef c8ef enabled auto-merge (squash) October 21, 2025 15:01
@c8ef c8ef merged commit abf80b5 into llvm:main Oct 21, 2025
14 of 17 checks passed
@c8ef
Copy link
Contributor Author

c8ef commented Oct 21, 2025

Oh, it seems like the auto merge isn't working as I expected. I think I have removed the correct macro.

@c8ef c8ef deleted the move branch October 21, 2025 15:05
c8ef added a commit to c8ef/llvm-project that referenced this pull request Oct 21, 2025
c8ef added a commit that referenced this pull request Oct 22, 2025
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
)

It seems this was accidentally included; there's no use of std::move in
this header.
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
)

It seems this was accidentally included; there's no use of std::move in
this header.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants