Skip to content

[mlir][spirv] Remove invalid canon pattern for GL.Length #164301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

[mlir][spirv] Remove invalid canon pattern for GL.Length #164301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,3 @@ def ConvertComparisonIntoClamp2_#CmpClampPair[0] : Pat<
)),
(CmpClampPair[1] $input, $min, $max)>;
}

//===----------------------------------------------------------------------===//
// spirv.GL.Length -> spirv.GL.FAbs
//===----------------------------------------------------------------------===//

def ConvertGLLengthToGLFAbs : Pat<
(SPIRV_GLLengthOp SPIRV_Float:$operand),
(SPIRV_GLFAbsOp $operand)>;
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/SPIRV/IR/SPIRVGLCanonicalization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ void populateSPIRVGLCanonicalizationPatterns(RewritePatternSet &results) {
ConvertComparisonIntoClamp2_SPIRV_SLessThanOp,
ConvertComparisonIntoClamp2_SPIRV_SLessThanEqualOp,
ConvertComparisonIntoClamp2_SPIRV_ULessThanOp,
ConvertComparisonIntoClamp2_SPIRV_ULessThanEqualOp,
ConvertGLLengthToGLFAbs>(results.getContext());
ConvertComparisonIntoClamp2_SPIRV_ULessThanEqualOp>(
results.getContext());
}
} // namespace spirv
} // namespace mlir
22 changes: 0 additions & 22 deletions mlir/test/Dialect/SPIRV/Transforms/gl-canonicalize.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,25 +177,3 @@ func.func @clamp_ulessthanequal(%input: i32, %min: i32, %max: i32) -> i32 {
// CHECK-NEXT: spirv.ReturnValue [[RES]]
spirv.ReturnValue %2 : i32
}

// -----

//===----------------------------------------------------------------------===//
// spirv.GL.Length
//===----------------------------------------------------------------------===//

// CHECK-LABEL: @convert_length_into_fabs_scalar
func.func @convert_length_into_fabs_scalar(%arg0 : f32) -> f32 {
//CHECK: spirv.GL.FAbs {{%.*}} : f32
//CHECK-NOT: spirv.GL.Length
%0 = spirv.GL.Length %arg0 : f32 -> f32
spirv.ReturnValue %0 : f32
}

// CHECK-LABEL: @dont_convert_length_into_fabs_vec
func.func @dont_convert_length_into_fabs_vec(%arg0 : vector<3xf32>) -> f32 {
//CHECK: spirv.GL.Length {{%.*}} : vector<3xf32> -> f32
//CHECK-NOT: spirv.GL.FAbs
%0 = spirv.GL.Length %arg0 : vector<3xf32> -> f32
spirv.ReturnValue %0 : f32
}
Loading