[LLDB][NativePDB] Require target-windows for func-symbols.test
#164406
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: nerix (Nerixyz) ChangesThe test builds files for Windows, so the target has to be required. Fixes the failure from #163733 (comment). Full diff: https://github.com/llvm/llvm-project/pull/164406.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/func-symbols.test b/lldb/test/Shell/SymbolFile/NativePDB/func-symbols.test
index 33ffad6b2f20f..ee96fa8fd5c33 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/func-symbols.test
+++ b/lldb/test/Shell/SymbolFile/NativePDB/func-symbols.test
@@ -1,4 +1,4 @@
-# REQUIRES: lld
+# REQUIRES: lld, target-windows
# Test that functions have the correct types.
# This uses the same input as SymbolFile/PDB/func-symbols.test. However, DIA
|
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
…lvm#164406) The test builds files for Windows, so the target has to be required. I didn't add this in llvm#163733. Fixes the failure from llvm#163733 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test builds files for Windows, so the target has to be required. I didn't add this in #163733.
Fixes the failure from #163733 (comment).