Skip to content

[lldb][test] When an external stdlib is specified do not link to the system stdlib #164462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
da-viper merged 2 commits into from
Oct 28, 2025
Merged

[lldb][test] When an external stdlib is specified do not link to the system stdlib #164462

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2da770c
[lldb][test] Do not link to the system stdlib
da-viper Oct 21, 2025
30065d2
Add review changes
da-viper Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lldb/packages/Python/lldbsuite/test/make/Makefile.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,11 @@ ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB)))
ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" ""
CXXFLAGS += -cxx-isystem $(LIBCPP_INCLUDE_TARGET_DIR)
endif

# If `-nostdlib++` is not passed, clang will link to the system's stdlib.
ifeq ($(LDC), clang)
Copy link
Member

@Michael137 Michael137 Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this. Clang, GCC and clang-cl are all aware of this option

Suggested change
ifeq ($(LDC), clang)

LDFLAGS += -nostdlib++ -nostdinc++
endif
LDFLAGS += -L$(LIBCPP_LIBRARY_DIR) -Wl,-rpath,$(LIBCPP_LIBRARY_DIR) -lc++
else
USE_SYSTEM_STDLIB := 1
Expand Down
Loading