[compiler-rt] Check if the compiler supports __has_feature first
#164689
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxuanchen1997
requested review from
Copilot,
kovdan01 and
ojhunt
and removed request for
Copilot
|
Closing in favor of #164535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line of code was introduced by e6a1aff.
This file fails to compile in some supported setups now, because
__has_featureitself being a macro is not implemented in GCC until 14: https://godbolt.org/z/eM9Gff157This fix should be simple, since ptrauth is only supported by apple clang, which should pass the
defined(__has_feature)condition, all other compilers that don't pass this condition can just assume the feature not being supported.