Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/ExecutionEngine/Orc/Core.h
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ class LLVM_ABI FailedToMaterialize : public ErrorInfo<FailedToMaterialize> {

FailedToMaterialize(std::shared_ptr<SymbolStringPool> SSP,
std::shared_ptr<SymbolDependenceMap> Symbols);
~FailedToMaterialize();
~FailedToMaterialize() override;
std::error_code convertToErrorCode() const override;
void log(raw_ostream &OS) const override;
const SymbolDependenceMap &getSymbols() const { return *Symbols; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class LLVM_ABI DebugObjectManagerPlugin : public ObjectLinkingLayer::Plugin {
DebugObjectManagerPlugin(ExecutionSession &ES,
std::unique_ptr<DebugObjectRegistrar> Target,
bool RequireDebugSections, bool AutoRegisterCode);
~DebugObjectManagerPlugin();
~DebugObjectManagerPlugin() override;

void notifyMaterializing(MaterializationResponsibility &MR,
jitlink::LinkGraph &G, jitlink::JITLinkContext &Ctx,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class LLVM_ABI PerfSupportPlugin : public ObjectLinkingLayer::Plugin {
ExecutorAddr RegisterPerfEndAddr,
ExecutorAddr RegisterPerfImplAddr, bool EmitDebugInfo,
bool EmitUnwindInfo);
~PerfSupportPlugin();
~PerfSupportPlugin() override;

void modifyPassConfig(MaterializationResponsibility &MR,
jitlink::LinkGraph &G,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class LLVM_ABI EPCGenericRTDyldMemoryManager
EPCGenericRTDyldMemoryManager(EPCGenericRTDyldMemoryManager &&) = delete;
EPCGenericRTDyldMemoryManager &
operator=(EPCGenericRTDyldMemoryManager &&) = delete;
~EPCGenericRTDyldMemoryManager();
~EPCGenericRTDyldMemoryManager() override;

uint8_t *allocateCodeSection(uintptr_t Size, unsigned Alignment,
unsigned SectionID,
Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/ExecutionEngine/Orc/IndirectionUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class LLVM_ABI IndirectStubsManager : public RedirectableSymbolManager {
/// Map type for initializing the manager. See init.
using StubInitsMap = StringMap<std::pair<ExecutorAddr, JITSymbolFlags>>;

virtual ~IndirectStubsManager() = default;
~IndirectStubsManager() override = default;

/// Create a single stub with the given name, target address and flags.
virtual Error createStub(StringRef StubName, ExecutorAddr StubAddr,
Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/ExecutionEngine/Orc/Layer.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class LLVM_ABI ObjectLayer : public RTTIExtends<ObjectLayer, RTTIRoot> {
static char ID;

ObjectLayer(ExecutionSession &ES);
virtual ~ObjectLayer();
~ObjectLayer() override;

/// Returns the execution session for this layer.
ExecutionSession &getExecutionSession() { return ES; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class LLVM_ABI LinkGraphLinkingLayer : public LinkGraphLayer,
std::unique_ptr<jitlink::JITLinkMemoryManager> MemMgr);

/// Destroy the LinkGraphLinkingLayer.
~LinkGraphLinkingLayer();
~LinkGraphLinkingLayer() override;

/// Add a plugin.
LinkGraphLinkingLayer &addPlugin(std::shared_ptr<Plugin> P) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class LLVM_ABI RTDyldObjectLinkingLayer
RTDyldObjectLinkingLayer(ExecutionSession &ES,
GetMemoryManagerFunction GetMemoryManager);

~RTDyldObjectLinkingLayer();
~RTDyldObjectLinkingLayer() override;

/// Emit the object.
void emit(std::unique_ptr<MaterializationResponsibility> R,
Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/ExecutionEngine/Orc/SimpleRemoteEPC.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class LLVM_ABI SimpleRemoteEPC : public ExecutorProcessControl,
SimpleRemoteEPC &operator=(const SimpleRemoteEPC &) = delete;
SimpleRemoteEPC(SimpleRemoteEPC &&) = delete;
SimpleRemoteEPC &operator=(SimpleRemoteEPC &&) = delete;
~SimpleRemoteEPC();
~SimpleRemoteEPC() override;

Expected<int32_t> runAsMain(ExecutorAddr MainFnAddr,
ArrayRef<std::string> Args) override;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace rt_bootstrap {
class LLVM_ABI ExecutorSharedMemoryMapperService final
: public ExecutorBootstrapService {
public:
~ExecutorSharedMemoryMapperService(){};
~ExecutorSharedMemoryMapperService() override {};

Expected<std::pair<ExecutorAddr, std::string>> reserve(uint64_t Size);
Expected<ExecutorAddr> initialize(ExecutorAddr Reservation,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace rt_bootstrap {
/// Simple page-based allocator.
class LLVM_ABI SimpleExecutorDylibManager : public ExecutorBootstrapService {
public:
virtual ~SimpleExecutorDylibManager();
~SimpleExecutorDylibManager() override;

Expected<tpctypes::DylibHandle> open(const std::string &Path, uint64_t Mode);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace rt_bootstrap {
/// Simple page-based allocator.
class LLVM_ABI SimpleExecutorMemoryManager : public ExecutorBootstrapService {
public:
virtual ~SimpleExecutorMemoryManager();
~SimpleExecutorMemoryManager() override;

Expected<ExecutorAddr> reserve(uint64_t Size);
Expected<ExecutorAddr> initialize(tpctypes::FinalizeRequest &FR);
Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/ExecutionEngine/Orc/TaskDispatch.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class LLVM_ABI Task : public RTTIExtends<Task, RTTIRoot> {
public:
static char ID;

virtual ~Task() = default;
~Task() override = default;

/// Description of the task to be performed. Used for logging.
virtual void printDescription(raw_ostream &OS) = 0;
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/ExecutionEngine/JITLink/JITLinkMemoryManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ class InProcessMemoryManager::IPInFlightAlloc
StandardSegments(std::move(StandardSegments)),
FinalizationSegments(std::move(FinalizationSegments)) {}

~IPInFlightAlloc() {
~IPInFlightAlloc() override {
assert(!G && "InFlight alloc neither abandoned nor finalized");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class MachODebugObjectSynthesizerBase

MachODebugObjectSynthesizerBase(LinkGraph &G, ExecutorAddr RegisterActionAddr)
: G(G), RegisterActionAddr(RegisterActionAddr) {}
virtual ~MachODebugObjectSynthesizerBase() = default;
~MachODebugObjectSynthesizerBase() override = default;

Error preserveDebugSections() {
if (G.findSectionByName(SynthDebugSectionName)) {
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class LinkGraphLinkingLayer::JITLinkCtx final : public JITLinkContext {
Plugins = Layer.Plugins;
}

~JITLinkCtx() {
~JITLinkCtx() override {
// If there is an object buffer return function then use it to
// return ownership of the buffer.
if (Layer.ReturnObjectBuffer && ObjBuffer)
Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class OrcCAPIMaterializationUnit : public llvm::orc::MaterializationUnit {
Name(std::move(Name)), Ctx(Ctx), Materialize(Materialize),
Discard(Discard), Destroy(Destroy) {}

~OrcCAPIMaterializationUnit() {
~OrcCAPIMaterializationUnit() override {
if (Ctx)
Destroy(Ctx);
}
Expand Down Expand Up @@ -264,7 +264,7 @@ class CAPIDefinitionGenerator final : public DefinitionGenerator {
LLVMOrcCAPIDefinitionGeneratorTryToGenerateFunction TryToGenerate)
: Dispose(Dispose), Ctx(Ctx), TryToGenerate(TryToGenerate) {}

~CAPIDefinitionGenerator() {
~CAPIDefinitionGenerator() override {
if (Dispose)
Dispose(Ctx);
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/ExecutionEngine/JITLink/JITLinkTestUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class MockJITLinkContext : public llvm::jitlink::JITLinkContext {
: JITLinkContext(&JD), MJMM(std::move(MJMM)),
HandleFailed(std::move(HandleFailed)) {}

~MockJITLinkContext() {
~MockJITLinkContext() override {
if (auto Err = MJMM->deallocate(std::move(FinalizedAllocs)))
notifyFailed(std::move(Err));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class EPCGenericMemoryAccessTest : public testing::Test {
MemAccess = std::make_unique<EPCGenericMemoryAccess>(*EPC, FAs);
}

~EPCGenericMemoryAccessTest() { cantFail(EPC->disconnect()); }
~EPCGenericMemoryAccessTest() override { cantFail(EPC->disconnect()); }

protected:
std::shared_ptr<SelfExecutorProcessControl> EPC;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ static int finalTarget() { return 53; }

class JITLinkRedirectionManagerTest : public testing::Test {
public:
~JITLinkRedirectionManagerTest() {
~JITLinkRedirectionManagerTest() override {
if (ES)
if (auto Err = ES->endSession())
ES->reportError(std::move(Err));
Expand Down
8 changes: 4 additions & 4 deletions llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ ArrayRef<char> BlockContent(BlockContentBytes);

class ObjectLinkingLayerTest : public testing::Test {
public:
~ObjectLinkingLayerTest() {
~ObjectLinkingLayerTest() override {
if (auto Err = ES.endSession())
ES.reportError(std::move(Err));
}
Expand Down Expand Up @@ -161,7 +161,7 @@ TEST_F(ObjectLinkingLayerTest, HandleErrorDuringPostAllocationPass) {
// abandon the in-flight allocation and report an error.
class TestPlugin : public ObjectLinkingLayer::Plugin {
public:
~TestPlugin() { EXPECT_TRUE(ErrorReported); }
~TestPlugin() override { EXPECT_TRUE(ErrorReported); }

void modifyPassConfig(MaterializationResponsibility &MR,
jitlink::LinkGraph &G,
Expand Down Expand Up @@ -215,7 +215,7 @@ TEST_F(ObjectLinkingLayerTest, AddAndRemovePlugins) {
TestPlugin(size_t &ActivationCount, bool &PluginDestroyed)
: ActivationCount(ActivationCount), PluginDestroyed(PluginDestroyed) {}

~TestPlugin() { PluginDestroyed = true; }
~TestPlugin() override { PluginDestroyed = true; }

void modifyPassConfig(MaterializationResponsibility &MR,
jitlink::LinkGraph &G,
Expand Down Expand Up @@ -336,7 +336,7 @@ TEST(ObjectLinkingLayerSearchGeneratorTest, AbsoluteSymbolsObjectLayer) {

class CheckDefs : public ObjectLinkingLayer::Plugin {
public:
~CheckDefs() { EXPECT_TRUE(SawSymbolDef); }
~CheckDefs() override { EXPECT_TRUE(SawSymbolDef); }

void modifyPassConfig(MaterializationResponsibility &MR,
jitlink::LinkGraph &G,
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/ExecutionEngine/Orc/OrcTestCommon.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace orc {
// (5) V -- A JITDylib associated with ES.
class CoreAPIsBasedStandardTest : public testing::Test {
public:
~CoreAPIsBasedStandardTest() {
~CoreAPIsBasedStandardTest() override {
if (auto Err = ES.endSession())
ES.reportError(std::move(Err));
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ using namespace llvm::jitlink;

class ReOptimizeLayerTest : public testing::Test {
public:
~ReOptimizeLayerTest() {
~ReOptimizeLayerTest() override {
if (ES)
if (auto Err = ES->endSession())
ES->reportError(std::move(Err));
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/ExecutionEngine/Orc/ResourceTrackerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class SimpleResourceManager : public ResourceManager {
SimpleResourceManager(SimpleResourceManager &&) = delete;
SimpleResourceManager &operator=(SimpleResourceManager &&) = delete;

~SimpleResourceManager() { ES.deregisterResourceManager(*this); }
~SimpleResourceManager() override { ES.deregisterResourceManager(*this); }

/// Set the HandleRemove function object.
void setHandleRemove(HandleRemoveFunction HandleRemove) {
Expand Down