Skip to content

[NativePDB] Fix crash in llvm-pdbutil #164871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

[NativePDB] Fix crash in llvm-pdbutil #164871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/DebugInfo/CodeView/LazyRandomTypeCollection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ std::optional<CVType> LazyRandomTypeCollection::tryGetType(TypeIndex Index) {
return std::nullopt;
}

assert(contains(Index));
if (!contains(Index))
return std::nullopt;
return Records[Index.toArrayIndex()].Type;
}

Expand Down
13 changes: 13 additions & 0 deletions llvm/test/DebugInfo/PDB/Native/pdb-native-index-overflow.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
; Test that the native PDB reader isn't crashed by index value bigger than
; number of types in TPI or IPI stream
; RUN: llvm-pdbutil dump %p/../Inputs/empty.pdb --type-index=20000000\
; RUN: | FileCheck -check-prefixes=TYPES,NOT_FOUND %s
; RUN: llvm-pdbutil dump %p/../Inputs/empty.pdb --id-index=20000000\
; RUN: | FileCheck -check-prefixes=IDS,NOT_FOUND %s

TYPES: Types (TPI Stream)
IDS: Types (IPI Stream)
NOT_FOUND:============================================================
NOT_FOUND: Showing 1 records.
NOT_FOUND: Type 0x1312D00 doesn't exist in TPI stream