Skip to content

ARM: Avoid adding default libcalls overridden by AEABI functions #164983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
Merged

ARM: Avoid adding default libcalls overridden by AEABI functions #164983

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66d3765
RuntimeLibcalls: Make sure _Unwind_Resume entries are mutually exclusive
arsenm Oct 19, 2025
a84fbd5
X86: Make sure compiler-rt div calls are not added for msvc
arsenm Oct 22, 2025
f615c5a
ARM: Avoid adding default libcalls overridden by AEABI functions
arsenm Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 65 additions & 5 deletions llvm/include/llvm/IR/RuntimeLibcalls.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ def ExceptionModelIsNotNone : RuntimeLibcallPredicate<
[{ExceptionModel != ExceptionHandling::None}]
>;

def ExceptionModelHasUnwindResume : RuntimeLibcallPredicate<
[{ExceptionModel != ExceptionHandling::None &&
ExceptionModel != ExceptionHandling::SjLj}]
>;

def ExceptionModelIsSjLj : RuntimeLibcallPredicate<
[{ExceptionModel == ExceptionHandling::SjLj}]
>;
Expand Down Expand Up @@ -1153,8 +1158,10 @@ def __ssp_canary_word : RuntimeLibcallImpl<STACK_CHECK_GUARD>;
//===----------------------------------------------------------------------===//

defvar ExceptionModelCalls = (add
LibcallImpls<(add DefaultExceptionHandlingLibcalls),
LibcallImpls<(add __cxa_end_cleanup),
ExceptionModelIsNotNone>,
LibcallImpls<(add _Unwind_Resume),
ExceptionModelHasUnwindResume>,
LibcallImpls<(add SjLjExceptionHandlingLibcalls),
ExceptionModelIsSjLj>
);
Expand Down Expand Up @@ -1396,8 +1403,10 @@ defset list<RuntimeLibcallImpl> WinArm64ECSjLjExceptionHandlingLibcalls = {
}

defvar ExceptionModelCallsArm64EC = (add
LibcallImpls<(add WinArm64ECDefaultExceptionHandlingLibcalls),
LibcallImpls<(add arm64ec___cxa_end_cleanup),
ExceptionModelIsNotNone>,
LibcallImpls<(add arm64ec__Unwind_Resume),
ExceptionModelHasUnwindResume>,
LibcallImpls<(add WinArm64ECSjLjExceptionHandlingLibcalls),
ExceptionModelIsSjLj>
);
Expand Down Expand Up @@ -1499,6 +1508,41 @@ def __aeabi_ddiv : RuntimeLibcallImpl<DIV_F64>; // CallingConv::ARM_AAPCS
def __aeabi_dmul : RuntimeLibcallImpl<MUL_F64>; // CallingConv::ARM_AAPCS
def __aeabi_dsub : RuntimeLibcallImpl<SUB_F64>; // CallingConv::ARM_AAPCS

defvar AEABIOverrides = [
__eqsf2, __eqdf2,
__nesf2, __nedf2,
__ltsf2, __ltdf2,
__lesf2, __ledf2,
__gesf2, __gedf2,
__gtsf2, __gtdf2,
__unordsf2, __unorddf2,

__addsf3, __adddf3,
__divsf3, __divdf3,
__mulsf3, __muldf3,
__subsf3, __subdf3,

__fixdfsi, __fixunsdfsi,
__fixdfdi, __fixunsdfdi,
__fixsfsi, __fixunssfsi,
__fixsfdi, __fixunssfdi,

__floatsidf, __floatunsidf,
__floatdidf, __floatundidf,
__floatsisf, __floatunsisf,
__floatdisf, __floatundisf,

__muldi3, __ashldi3,
__lshrdi3, __ashrdi3,

__divsi3, __udivsi3

// Half conversion cases are a mess and handled separately.
// __truncdfsf2, __truncdfhf2,
// __extendsfdf2,
// __truncsfhf2, __extendhfsf2
];

// Double-precision floating-point comparison helper functions
// RTABI chapter 4.1.2, Table 3
def __aeabi_dcmpeq__oeq : RuntimeLibcallImpl<OEQ_F64, "__aeabi_dcmpeq">; // CallingConv::ARM_AAPCS, CmpInst::ICMP_NE
Expand Down Expand Up @@ -1784,7 +1828,8 @@ def ARMSystemLibrary
: SystemRuntimeLibrary<isARMOrThumb,
(add (sub WinDefaultLibcallImpls, ARMLibgccHalfConvertCalls,
GNUEABIHalfConvertCalls,
ARMDoubleToHalfCalls),
ARMDoubleToHalfCalls,
AEABIOverrides),
LibcallImpls<(add __powisf2, __powidf2), isNotOSMSVCRT>,
LibmHasFrexpF32, LibmHasLdexpF32,
LibmHasFrexpF128, LibmHasLdexpF128,
Expand All @@ -1803,6 +1848,11 @@ def ARMSystemLibrary
GNUEABIHalfConvertCalls,
ARMDoubleToHalfCalls,

LibcallImpls<(add AEABIOverrides),
RuntimeLibcallPredicate<[{
(!hasAEABILibcalls(TT) || !isAAPCS_ABI(TT, ABIName)) &&
!TT.isOSWindows()
}]>>,
// Use divmod compiler-rt calls for iOS 5.0 and later.
LibcallImpls<(add __divmodsi4, __udivmodsi4),
RuntimeLibcallPredicate<[{TT.isOSBinFormatMachO() &&
Expand Down Expand Up @@ -2443,6 +2493,11 @@ def _aullrem : RuntimeLibcallImpl<UREM_I64>;
def _allmul : RuntimeLibcallImpl<MUL_I64>;
}

// FIXME: Should have utility function to filter by known provider.
defvar WindowsDivRemMulLibcallOverrides = [
__divdi3, __udivdi3, __moddi3, __umoddi3, __muldi3
];

//===----------------------------------------------------------------------===//
// X86 Runtime Libcalls
//===----------------------------------------------------------------------===//
Expand All @@ -2464,7 +2519,7 @@ defvar X86_F128_Libcalls = LibcallImpls<(add LibmF128Libcalls, LibmF128FiniteLib
defvar SinCosF32F64Libcalls = LibcallImpls<(add sincosf, sincos), hasSinCos_f32_f64>;

defvar X86CommonLibcalls =
(add WinDefaultLibcallImpls,
(add (sub WinDefaultLibcallImpls, WindowsDivRemMulLibcallOverrides),
DarwinSinCosStret, DarwinExp10,
X86_F128_Libcalls,
LibmHasSinCosF80, // FIXME: Depends on long double
Expand All @@ -2487,10 +2542,15 @@ defvar Windows32DivRemMulCalls =
LibcallsWithCC<(add WindowsDivRemMulLibcalls), X86_STDCALL,
RuntimeLibcallPredicate<"TT.isWindowsMSVCEnvironment() || TT.isWindowsItaniumEnvironment()">>;

defvar NotWindows32DivRemMulCalls =
LibcallImpls<(add WindowsDivRemMulLibcallOverrides),
RuntimeLibcallPredicate<"!TT.isWindowsMSVCEnvironment() && !TT.isWindowsItaniumEnvironment()">>;

def X86_32SystemLibrary
: SystemRuntimeLibrary<isX86_32,
(add X86CommonLibcalls,
Windows32DivRemMulCalls)>;
NotWindows32DivRemMulCalls,
Windows32DivRemMulCalls)>;

def X86_64SystemLibrary
: SystemRuntimeLibrary<isX86_64,
Expand Down