Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions libcxx/include/__functional/bind_front.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include <__type_traits/decay.h>
#include <__type_traits/enable_if.h>
#include <__type_traits/is_constructible.h>
#include <__type_traits/is_member_pointer.h>
#include <__type_traits/is_pointer.h>
#include <__utility/forward.h>

#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
Expand Down Expand Up @@ -49,6 +51,53 @@ _LIBCPP_HIDE_FROM_ABI constexpr auto bind_front(_Fn&& __f, _Args&&... __args) {

#endif // _LIBCPP_STD_VER >= 20

#if _LIBCPP_STD_VER >= 26

template <auto _Fn, class _Indices, class... _BoundArgs>
struct __nttp_bind_front_t;

template <auto _Fn, size_t... _Indices, class... _BoundArgs>
struct __nttp_bind_front_t<_Fn, index_sequence<_Indices...>, _BoundArgs...> {
tuple<_BoundArgs...> __bound_args_;

template <class _Self, class... _Args>
_LIBCPP_HIDE_FROM_ABI constexpr auto operator()(this _Self&& __self, _Args&&... __args) noexcept(noexcept(std::invoke(
_Fn, std::get<_Indices>(std::forward<_Self>(__self).__bound_args_)..., std::forward<_Args>(__args)...)))
-> decltype(std::invoke(
_Fn, std::get<_Indices>(std::forward<_Self>(__self).__bound_args_)..., std::forward<_Args>(__args)...)) {
return std::invoke(
_Fn, std::get<_Indices>(std::forward<_Self>(__self).__bound_args_)..., std::forward<_Args>(__args)...);
}
};

template <auto _Fn>
struct __nttp_bind_without_bound_args_t {
template <class... _Args>
_LIBCPP_HIDE_FROM_ABI static constexpr auto
operator()(_Args&&... __args) noexcept(noexcept(std::invoke(_Fn, std::forward<_Args>(__args)...)))
-> decltype(std::invoke(_Fn, std::forward<_Args>(__args)...)) {
return std::invoke(_Fn, std::forward<_Args>(__args)...);
}
};

template <auto _Fn, class... _Args>
[[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto bind_front(_Args&&... __args) {
static_assert((is_constructible_v<decay_t<_Args>, _Args> && ...),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also test these static_assert in a verify test?

"bind_front requires all decay_t<Args> to be constructible from respective Args");
static_assert((is_move_constructible_v<decay_t<_Args>> && ...),
"bind_front requires all decay_t<Args> to be move constructible");
if constexpr (using _Ty = decltype(_Fn); is_pointer_v<_Ty> || is_member_pointer_v<_Ty>)
static_assert(_Fn != nullptr, "f cannot be equal to nullptr");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps mention bind_front in the message as you did in other messages?
Could we have a verify test where we pass a nullptr and this static assertion triigered?


if constexpr (sizeof...(_Args) == 0)
return __nttp_bind_without_bound_args_t<_Fn>{};
else
return __nttp_bind_front_t<_Fn, index_sequence_for<_Args...>, decay_t<_Args>...>{
.__bound_args_{std::forward<_Args>(__args)...}};
}

#endif // _LIBCPP_STD_VER >= 26

_LIBCPP_END_NAMESPACE_STD

#endif // _LIBCPP___FUNCTIONAL_BIND_FRONT_H
2 changes: 2 additions & 0 deletions libcxx/include/functional
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,8 @@ template <auto f>
// [func.bind.partial], function templates bind_front and bind_back
template<class F, class... Args>
constexpr unspecified bind_front(F&&, Args&&...); // C++20
template<auto f, class... Args>
constexpr unspecified bind_front(Args&&...); // C++26
template<class F, class... Args>
constexpr unspecified bind_back(F&&, Args&&...); // C++23

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// REQUIRES: std-at-least-c++26

// <functional>

// Type of `std::bind_front<NTTP>(/* no bound args */)` is empty.

#include <functional>
#include <type_traits>

struct NonEmptyFunctionObject {
int val = true;
void operator()() const;
};

void func();

struct SomeClass {
long member_object;
void member_function();
};

using ResultWithEmptyFuncObject = decltype(std::bind_front<std::integral_constant<int, 0>{}>());
static_assert(std::is_empty_v<ResultWithEmptyFuncObject>);

using ResultWithNotEmptyFuncObject = decltype(std::bind_front<NonEmptyFunctionObject{}>());
static_assert(std::is_empty_v<ResultWithNotEmptyFuncObject>);

using ResultWithFunctionPointer = decltype(std::bind_front<func>());
static_assert(std::is_empty_v<ResultWithFunctionPointer>);

using ResultWithMemberObjectPointer = decltype(std::bind_front<&SomeClass::member_object>());
static_assert(std::is_empty_v<ResultWithMemberObjectPointer>);

using ResultWithMemberFunctionPointer = decltype(std::bind_front<&SomeClass::member_function>());
static_assert(std::is_empty_v<ResultWithMemberFunctionPointer>);
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// REQUIRES: std-at-least-c++26

// <functional>

// Test the libc++ extension that std::bind_front<NTTP> is marked as [[nodiscard]].

#include <functional>

void test() {
std::bind_front<test>(); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
}
Loading
Loading