[NSan] Make Tests work with Internal Shell #165142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Aiden Grossman (boomanaiden154) ChangesThere was one test that was using a subshell. This is not supported by Full diff: https://github.com/llvm/llvm-project/pull/165142.diff 1 Files Affected:
diff --git a/compiler-rt/test/nsan/Posix/allocator_mapping.cpp b/compiler-rt/test/nsan/Posix/allocator_mapping.cpp
index 3a3e655e259d0..a92962e16d9d2 100644
--- a/compiler-rt/test/nsan/Posix/allocator_mapping.cpp
+++ b/compiler-rt/test/nsan/Posix/allocator_mapping.cpp
@@ -2,7 +2,8 @@
/// Test that a module constructor can not map memory over the NSan heap
/// (without MAP_FIXED, of course).
// RUN: %clangxx_nsan -O0 %s -o %t_1
-// RUN: %clangxx_nsan -O0 -DHEAP_ADDRESS=$(%run %t_1) %s -o %t_2 && %run %t_2
+// RUN: %run %t_1 > %t.heap_address
+// RUN: %clangxx_nsan -O0 -DHEAP_ADDRESS=%{readfile:%t.heap_address} %s -o %t_2 && %run %t_2
#include <assert.h>
#include <stdio.h>
|
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 26, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Pull Request: llvm#165142
fmayer
approved these changes
Oct 27, 2025
Created using spr 1.3.7 [skip ci]
alexander-shaposhnikov
approved these changes
Oct 28, 2025
Created using spr 1.3.7 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Pull Request: llvm#165142
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Pull Request: llvm#165142
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Pull Request: llvm#165142
Created using spr 1.3.7 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.nsan-make-tests-work-with-internal-shell
to
main
boomanaiden154
deleted the
users/boomanaiden154/nsan-make-tests-work-with-internal-shell
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 30, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Reviewers: alexander-shaposhnikov, fmayer Reviewed By: alexander-shaposhnikov, fmayer Pull Request: llvm/llvm-project#165142
luciechoi
pushed a commit
to luciechoi/llvm-project
that referenced
this pull request
Nov 1, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Reviewers: alexander-shaposhnikov, fmayer Reviewed By: alexander-shaposhnikov, fmayer Pull Request: llvm#165142
DEBADRIBASAK
pushed a commit
to DEBADRIBASAK/llvm-project
that referenced
this pull request
Nov 3, 2025
There was one test that was using a subshell. This is not supported by lit's internal shell. Rewrite the test to use the readfile substitution. Reviewers: alexander-shaposhnikov, fmayer Reviewed By: alexander-shaposhnikov, fmayer Pull Request: llvm#165142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one test that was using a subshell. This is not supported by
lit's internal shell. Rewrite the test to use the readfile substitution.