Skip to content

[Clang][OpenMP] Bug fix Default clause variable category #165276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 14, 2025
Merged

[Clang][OpenMP] Bug fix Default clause variable category #165276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
822dd15
1) In the default clause, changing check for allocatable type in
Oct 27, 2025
60af1ee
Merge branch 'main' into bug_fix_variable_category
SunilKuravinakop Oct 27, 2025
10fef55
Merge branch 'main' into bug_fix_variable_category
SunilKuravinakop Oct 27, 2025
f6ef21e
1) Correcting the expected output of llvm IR in clang/test/OpenMP/par…
Nov 6, 2025
8329e11
Merge branch 'main' into bug_fix_variable_category
Nov 6, 2025
99310f5
Removing unnecessary variable in the CHECK: for
Nov 6, 2025
d96b1ff
Merge branch 'main' into bug_fix_variable_category
Nov 6, 2025
ee86fd0
Changes to avoid failure on Windows.
Nov 7, 2025
d4ee726
Taking care of llvm-lit failure on windows.
Nov 11, 2025
528fd62
Removing handling of "allocatable". I do not find a way to handle it at
Nov 13, 2025
f7178a8
Avoiding compilation error with Ninja.
Nov 13, 2025
cc1c533
Merge branch 'main' into bug_fix_variable_category
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clang/lib/Sema/SemaOpenMP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,15 +1364,15 @@ DSAStackTy::DSAVarData DSAStackTy::getDSA(const_iterator &Iter,
DefaultDataSharingAttributes IterDA = Iter->DefaultAttr;
switch (Iter->DefaultVCAttr) {
case DSA_VC_aggregate:
if (!VD->getType()->isAggregateType())
if (!D->getType()->isAggregateType())
IterDA = DSA_none;
break;
case DSA_VC_pointer:
if (!VD->getType()->isPointerType())
if (!D->getType()->isPointerType())
IterDA = DSA_none;
break;
case DSA_VC_scalar:
if (!VD->getType()->isScalarType())
if (!D->getType()->isScalarType())
IterDA = DSA_none;
break;
case DSA_VC_all:
Expand Down
92 changes: 92 additions & 0 deletions clang/test/OpenMP/parallel_default_variableCategory_codegen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
// RUN: %clangxx -Xclang -verify -Wno-vla -fopenmp -fopenmp-version=60 -x c++ -S -emit-llvm %s -o - | FileCheck %s
// expected-no-diagnostics
#ifndef HEADER
#define HEADER

#include <vector>

int global;
#define VECTOR_SIZE 4
int main (int argc, char **argv) {
int i,n;
int x;

n = VECTOR_SIZE;

#pragma omp parallel masked firstprivate(x) num_threads(2)
{
int *xPtr = nullptr;
// scalar
#pragma omp task default(shared:scalar)
{
xPtr = &x;
}
#pragma omp taskwait

// pointer
#pragma omp task default(shared:pointer) shared(x)
{
xPtr = &x;
}
#pragma omp taskwait
}

int *aggregate[VECTOR_SIZE] = {0,0,0,0};

#pragma omp parallel masked num_threads(2)
{
// aggregate
#pragma omp task default(shared:aggregate)
for(i=0;i<n;i++) {
aggregate[i] = &x;
}
#pragma omp taskwait

#pragma omp task default(shared:aggregate) shared(x)
for(i=0;i<n;i++) {
aggregate[i] = &x;
}
#pragma omp taskwait

// all
#pragma omp task default(shared:all)
for(i=0;i<n;i++) {
aggregate[i] = &x;
}
#pragma omp taskwait
}
}

#endif

// CHECK-LABEL: define {{.*}}main.omp_outlined{{.*}}
// CHECK-NEXT: entry:
// CHECK: %x.addr = alloca{{.*}}
// CHECK: %xPtr = alloca{{.*}}
// CHECK: store ptr null, ptr %xPtr{{.*}}
// CHECK: store ptr %xPtr{{.*}}
// CHECK: store ptr %x.addr{{.*}}
// CHECK-NEXT: {{.*}}call{{.*}}__kmpc_omp_task_alloc{{.*}}
// CHECK: ret void
//
// CHECK: define {{.*}}main.omp_outlined{{.*}}
// CHECK-NEXT: entry:
// CHECK-DAG: %i.addr = alloca{{.*}}
// CHECK-DAG: %n.addr = alloca{{.*}}
// CHECK-DAG: %aggregate.addr = alloca{{.*}}
// CHECK-DAG: %x.addr = alloca{{.*}}
// CHECK: [[TMP0:%.*]] = load{{.*}}%i.addr{{.*}}
// CHECK-NEXT: [[TMP1:%.*]] = load{{.*}}%n.addr{{.*}}
// CHECK-NEXT: [[TMP2:%.*]] = load{{.*}}%aggregate.addr{{.*}}
// CHECK-NEXT: [[TMP3:%.*]] = load{{.*}}%x.addr{{.*}}
// CHECK: store ptr [[TMP2]]{{.*}}
// CHECK-NEXT: {{.*}}call{{.*}}__kmpc_omp_task_alloc{{.*}}
// CHECK: store ptr [[TMP2]]{{.*}}
// CHECK: store ptr [[TMP3]]{{.*}}
// CHECK-NEXT: {{.*}}call{{.*}}__kmpc_omp_task_alloc{{.*}}
// CHECK: store ptr [[TMP0]]{{.*}}
// CHECK: store ptr [[TMP1]]{{.*}}
// CHECK: store ptr [[TMP2]]{{.*}}
// CHECK: store ptr [[TMP3]]{{.*}}
// CHECK-NEXT: {{.*}}call{{.*}}__kmpc_omp_task_alloc{{.*}}
// CHECK: ret void
Loading